In #1806334: Replace the node listing at /node with a view it became clear that we still require the node module and it's view in one of our basic tests.
Let's use the views_test_data table for that and simplify some of the code using a relationshipPluginBase.

CommentFileSizeAuthor
#7 drupal-1893850-7.patch8.43 KBdawehner
#7 interdiff.txt1.78 KBdawehner
#4 views-1893850-3.patch8.28 KBxjm
#4 interdiff.txt1.85 KBxjm
#1 drupal-1893850-1.patch6.43 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new drupal-1893850-1.patch6.43 KB

There we go.

xjm’s picture

xjm
she/her
Primary language English
commented 
+++ b/core/modules/views/lib/Drupal/views/Tests/Handler/RelationshipTest.phpundefined
@@ -8,13 +8,14 @@
+use Drupal\views\Tests\Plugin\RelationshipJoinTestBase;

I think we need to move this class over too? It's missing from the patch.

Status: Needs review » Needs work

The last submitted patch, drupal-1893850-1.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.85 KB
new views-1893850-3.patch8.28 KB
dawehner’s picture

dawehner
Primary language German
commented

I not often use patch -p1, but when I do, it fails completely.

+++ b/core/modules/views/lib/Drupal/views/Tests/Plugin/JoinTest.phpundefined
@@ -61,14 +64,14 @@ public function testExamplePlugin() {
+    debug($join_info['condition']);

So would removing a debug message be out of scope here ^^

The rest looks really sane for me, but afaik I wrote that change in the original issue in the first place, so I don't RTBC it.

Status: Needs review » Needs work

The last submitted patch, views-1893850-3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new interdiff.txt1.78 KB
new drupal-1893850-7.patch8.43 KB

The first test failure seems to be random.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Needs review
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Yep, this all looks good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Seems reasonable to split that out.

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.