TCPDF chokes on imagemagick [#1893980]

I am getting the following exception when using print_pdf and TCPDF 5.9.202 and 5.9.120 (I needed to hack print_pdf.pages.inc with some error reporting to see it):

ImagickException Object
(
    [message:protected] => unable to open file `/home/.../www/.../drupal-7.x/file:/home/.../www/.../drupal-7.x/sites/default/files/logo2013-2-64_0.png' @ png.c/ReadPNGImage/2921
    [string:private] => 
    [code:protected] => 1
    [file:protected] => /home/.../www/.../drupal-7.x/sites/all/libraries/tcpdf-5.9.120/tcpdf.php
    [line:protected] => 8109
    [trace:private] => Array
        (
            [0] => Array
                (
                    [file] => /home/.../www/.../drupal-7.x/sites/all/libraries/tcpdf-5.9.120/tcpdf.php
                    [line] => 8109
                    [function] => readimage
                    [class] => Imagick
                    [type] => ->
                    [args] => Array
                        (
                            [0] => file:///home/.../www/.../drupal-7.x/sites/default/files/logo2013-2-64_0.png
                        )

Reviewing the code, I see that _print_pdf_file_access_images() converts all private images to "file://" streamwrapper. While TCPDF itself seems to handle those OK, TCPDF calls Imagick and passes file names directly (i.e. $img = new Imagick(); $img->readImage($file);). Imagick is not handling streamwrapper file names and throws the above exception.

Comment	File	Size	Author
#3	print_pdf-imagemagick-1893980-3.patch	1.17 KB	yang_yi_cn
#1	print_tcpdf_private-1893980-1.patch	6.05 KB	iva2k

Comments

Comment #1

iva2k commented 20 January 2013 at 23:08

Status:

Active

» Needs review

Status	File	Size
new	print_tcpdf_private-1893980-1.patch	6.05 KB

In case anyone is interested, here's a patch that includes:

TCPDF class error reporting pass-through
TCPDF catch exceptions and log to watchdog
TCPDF remove stramwrappers for Imagick compatibility
TCPDF Fixed last slash in K_PATH_CACHE

Comment #2

yang_yi_cn commented 5 February 2013 at 17:42

I'm definitely interested, having the same problem for the 6.x version as well.

I believe the 6.x version doesn't use streamwrapper. However I do have a question is that why the TCPDF try to use ImageMagick at all? Although it is available, my image API toolkit is set to use GD.