add feedback loop / reject

There is no reject/review thing in the workflow. The only thing we can do is to submit comments to a project. See the attached patch for the functionality.

Comments are attached to the review screen. The reason is that we map job item to oht project and there is no other screen dealing with job item itself. Also it makes sense to provide comment feature during the review process.

+++ b/tmgmt_oht.moduleundefined
@@ -24,6 +24,119 @@ function tmgmt_oht_tmgmt_translator_plugin_info() {
+function tmgmt_oht_form_tmgmt_ui_node_translation_review_form_alter(&$form, &$form_state) {
+  /* @var TMGMTJobItem $job_item */
+  $job_item = $form_state['item'];
+  $translator = $job_item->getTranslator();
+  if ($translator->name != 'oht') {
+    return;

You should be able to use the reviewForm() method of the translator UI controller. That's exactly why we added it :)

Then you don't need the translator check (which is wrong, name can be anything, the plugin must be oht ;))

+++ b/tmgmt_oht.moduleundefined
@@ -24,6 +24,119 @@ function tmgmt_oht_tmgmt_translator_plugin_info() {
+          'data' => t('By %name (%role) at %time', array(
+            '%name' => check_plain($comment['commenter_name']),
+            '%role' => check_plain($comment['commenter_role']),
+            '%time' => format_date(strtotime($comment['date']))

%placeholders are automatically check_plain()'d. So you must not call it again or it would be double encoded.

+++ b/tmgmt_oht.moduleundefined
@@ -24,6 +24,119 @@ function tmgmt_oht_tmgmt_translator_plugin_info() {
+    '#prefix' => '<a name="comments-top" id="comments-top"></a>'

I think any id can be accessed with a #fragment, so you can just add the id to the fieldset.

+++ b/tmgmt_oht.moduleundefined
@@ -24,6 +24,119 @@ function tmgmt_oht_tmgmt_translator_plugin_info() {
+    '#type' => 'markup',
+    '#markup' => theme('table', array('rows' => $rows)),

You can use #theme => table and #rows => $rows. And maybe add an #empty => t('No comments')?

+++ b/tmgmt_oht.moduleundefined
@@ -24,6 +24,119 @@ function tmgmt_oht_tmgmt_translator_plugin_info() {
+    drupal_set_message($e->getMessage(), 'error');

Not sure if drupal_set_message() is check_plain()'ed. Also, not sure what the exception exactly returns, maybe add something like "Failed to submit comment: @error".

Comments implemented

Thanks, commited.