Allowed file extensions not set on file/add when multiform is enabled [#1894814]

When multiform is not enabled, file/add invokes drupal_get_form('file_entity_add_upload'), so media_form_file_entity_add_upload_alter() alters the form and injects Media's allowed file extensions. When multiform is enabled, file/add invokes a different form; 'file_entity_add_upload_multiple'. So, the form alter hook is never called, and Media's default file extensions are never added.

Patch coming

Comment	File	Size	Author
#7	File system 2013-07-18 12-00-45.jpg	114.44 KB	gmclelland
#5	before-patch.jpg	134.84 KB	gmclelland
#5	after-patch.jpg	139.98 KB	gmclelland
#5	media-allowed_file_extensions_multiform-1894814-6.patch	1.08 KB	gmclelland
#1	media-allowed_file_extensions_multiform-1894814-1.patch	2.02 KB	mstef

Comments

Comment #1

mstef commented 21 January 2013 at 18:10

Status:

Active

» Needs review

Status	File	Size
new	media-allowed_file_extensions_multiform-1894814-1.patch	2.02 KB

Here's a simple patch. It removes media_form_file_entity_add_upload_alter() and places a switch() inside media_form_alter() that will execute the same code for either file_entity_add_upload or file_entity_add_upload_multiple.

Comment #2

kenianbei commented 11 February 2013 at 14:42

Patch seems to work for me.

Comment #3

ParisLiakos commented 11 February 2013 at 16:36

+++ b/media.moduleundefined
@@ -524,6 +524,21 @@ function media_form_alter(&$form, &$form_state, $form_id) {
+  ¶

whitespace detected:P

Comment #4

rooby commented 12 February 2013 at 03:18

Status:

Needs review

» Needs work

A couple of minor coding standards fixes required:

+++ b/media.module
@@ -524,6 +524,21 @@ function media_form_alter(&$form, &$form_state, $form_id) {
+  ¶

Unnecessary white space.

+++ b/media.module
@@ -524,6 +524,21 @@ function media_form_alter(&$form, &$form_state, $form_id) {
+        // If the list of allowed extensions is the default provided by file_entity

Comments should not exceed 80 characters per line.

Comment #5

gmclelland commented 21 June 2013 at 01:02

Status:

Needs work

» Needs review

Status	File	Size
new	media-allowed_file_extensions_multiform-1894814-6.patch	1.08 KB
new	after-patch.jpg	139.98 KB
new	before-patch.jpg	134.84 KB

Thanks @mstef - I tested your patch and it fixed the problem for me. Without this patch, I wasn't able to upload an mp4 video. See the attached screenshots for details on what this patch does.

I rerolled the patch to fix the white space errors and the comments characters per line. I would set this to RBTC, but I will let someone else make the change.

Comment #6

mstef commented 21 June 2013 at 13:46

my mistake..

Comment #7

gmclelland commented 18 July 2013 at 17:04

Status:

Needs review

» Closed (fixed)

Status	File	Size
new	File system 2013-07-18 12-00-45.jpg	114.44 KB

I could be wrong, but I think this patch is no longer needed. With the latest 2.x-devs of media and file entity you can go to admin/config/media/file-system you will see a new field for "Default allowed file extensions." File/add will use the extensions there.

File system 2013-07-18 12-00-45.jpg