There's been a few improvements to the CMF Routing component, including one small API change: https://github.com/symfony-cmf/Routing/commit/d0b651467366446dba8011c172...

We're still doing a bigger update of all our dependencies in #1894002: Update vendor libraries and pin them to specific versions in composer.json, but since this one has an API change let's do it separately and pin to a specific commit object here first, just to keep things easier.

The API change is just changing the _route and _route_name attribute names to _route and _route_object, which are now defined by constants that we should be using instead. No other changes necessary as far as I know.

Comments

scor’s picture

Status: Active » Needs review
Issue tags: +WSCCI
StatusFileSize
new33.25 KB
new3.06 KB

replaced all our _route to RouteObjectInterface::ROUTE_OBJECT. I could not find any instance of _route_name.

The for_testing patch includes the updated symfony-cmf lib.

Crell’s picture

Thanks, scor. Can you go ahead and pin the CMF Routing component at a specific commit (whatever you've got here is fine, I assume that's current head), so that it doesn't move out from under us? May as well get a jump on that issue if we can.

Once that's done this is RTBC.

Crell’s picture

Status: Needs review » Needs work
scor’s picture

Shouldn't we leave the pinning job to #1894002: Update vendor libraries and pin them to specific versions in composer.json?

In my mind the goal of this issue was to prepare the ground for pinning our dependencies, so that #1894002: Update vendor libraries and pin them to specific versions in composer.json doesn't fail.

scor’s picture

Status: Needs work » Needs review
StatusFileSize
new3.63 KB
new33.72 KB

discussed this with @crell and @msonnabaum and decided to also handle the pinning in this issue.

Crell’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, scor.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.