There's been a few improvements to the CMF Routing component, including one small API change: https://github.com/symfony-cmf/Routing/commit/d0b651467366446dba8011c172...
We're still doing a bigger update of all our dependencies in #1894002: Update vendor libraries and pin them to specific versions in composer.json, but since this one has an API change let's do it separately and pin to a specific commit object here first, just to keep things easier.
The API change is just changing the _route and _route_name attribute names to _route and _route_object, which are now defined by constants that we should be using instead. No other changes necessary as far as I know.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 1894934-cmf-routing-update-5.patch | 33.72 KB | scor |
| #5 | interdiff.txt | 3.63 KB | scor |
| #1 | 1894934-cmf-routing-update-1__for_review.txt | 3.06 KB | scor |
| #1 | 1894934-cmf-routing-update-1__for_testing.patch | 33.25 KB | scor |
Comments
Comment #1
scor commentedreplaced all our _route to RouteObjectInterface::ROUTE_OBJECT. I could not find any instance of _route_name.
The for_testing patch includes the updated symfony-cmf lib.
Comment #2
Crell commentedThanks, scor. Can you go ahead and pin the CMF Routing component at a specific commit (whatever you've got here is fine, I assume that's current head), so that it doesn't move out from under us? May as well get a jump on that issue if we can.
Once that's done this is RTBC.
Comment #3
Crell commentedComment #4
scor commentedShouldn't we leave the pinning job to #1894002: Update vendor libraries and pin them to specific versions in composer.json?
In my mind the goal of this issue was to prepare the ground for pinning our dependencies, so that #1894002: Update vendor libraries and pin them to specific versions in composer.json doesn't fail.
Comment #5
scor commenteddiscussed this with @crell and @msonnabaum and decided to also handle the pinning in this issue.
Comment #6
Crell commentedThanks, scor.
Comment #7
webchickCommitted and pushed to 8.x. Thanks!