Download & Extend

Convert some token tests to DrupalUnitTestBase

Project:Drupal core
Version:8.x-dev
Component:token system
Category:task
Priority:normal
Assigned:Unassigned
Status:needs review
Issue tags:Test suite performance

Issue Summary

With patch

Drupal test run
---------------

Tests to be run:
- Node and user token replacement (Drupal\system\Tests\System\TokenReplaceTest)
- Token replacement unit test (Drupal\system\Tests\System\TokenReplaceUnitTest)

Test run started:
Monday, January 21, 2013 - 23:20

Test summary
------------

Node and user token replacement 6 passes, 0 fails, and 0 exceptions
Token replacement unit test 30 passes, 0 fails, and 0 exceptions

Test run duration: 6 sec

real 0m6.435s
user 0m5.087s
sys 0m0.352s

without patch

Drupal test run
---------------

Tests to be run:
- Token replacement (Drupal\system\Tests\System\TokenReplaceTest)

Test run started:
Monday, January 21, 2013 - 23:22

Test summary
------------

Token replacement 36 passes, 0 fails, and 0 exceptions

Test run duration: 19 sec

real 0m20.438s
user 0m16.275s
sys 0m0.930s
AttachmentSizeStatusTest resultOperations
drupal8.token-unit-test.patch11.28 KBIdlePASSED: [[SimpleTest]]: [MySQL] 50,666 pass(es).View details | Re-test

Comments

#1

Status:active» needs review

Go bot...

#2

#3

Status:needs review» needs work

+++ b/core/modules/system/lib/Drupal/system/Tests/System/TokenReplaceUnitTest.phpundefined
@@ -0,0 +1,140 @@
+    // Install default system configuration.
+    config_install_default_config('module', 'system');

This should now use $this->installConfig()

#4

Status:needs work» needs review

Re-roll.

AttachmentSizeStatusTest resultOperations
token-unit-test-1895018-4.patch11.27 KBIdlePASSED: [[SimpleTest]]: [MySQL] 52,406 pass(es).View details | Re-test
nobody click here