Since this commit in Nov 2012 hook_twitter_account_save() is invoked with only one argument $values; twitter.api.php needs to be updated to reflect this.

As I'm going to implement this hook anyway, I might well fix this along the way.

CommentFileSizeAuthor
#14 twitter-n1895320-14.patch3.98 KBdamienmckenna
#13 twitter-n1895320-12.patch552 bytesdamienmckenna
#10 twitter-n1895320-10.patch4.09 KBdamienmckenna
#3 twitter-Update_API_documentation_for_hook_twitter_account_save-1895320-3.patch4.42 KBDrave Robber

Comments

juampynr’s picture

juampynr commented

Patch?

Drave Robber’s picture

Drave Robber commented

Later today. :)

Drave Robber’s picture

Drave Robber commented
Title: API documentation for hook_twitter_account_save() is outdated » Update API documentation for hook_twitter_account_save()
Assigned: Drave Robber » Unassigned
Status: Active » Needs review
StatusFileSize
new twitter-Update_API_documentation_for_hook_twitter_account_save-1895320-3.patch4.42 KB

Patch attached. Relevant CS were followed.

I left other hooks alone for now, might pay some attention when I get to implementing them. 62 lines of Doxygen is enough for a normal day, after all. :D

13rac1’s picture

13rac1 commented
Status: Needs review » Reviewed & tested by the community

Nice work Drave! Patch applies cleanly.

pavlosdan’s picture

pavlosdan
he/him/his
Primary language Greek
Location Vancouver
commented

+1 For getting this in.

We are using this hook to fire a Rules event but we were getting a whitescreen when Twitter redirected the user back to our site with an

EntityMetadataWrapperException: Invalid data value given. Be sure it matches the required data type and format. in EntityDrupalWrapper->set() (line 744 of /var/www/site/public_html/sites/all/modules/entity/includes/entity.wrapper.inc).

error and an
"Unauthorized" error from Twitter in the error log.

Correct documentation would have saved us a lot of time in debugging this :)

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
Parent issue: » #2402307: Plan for Twitter v7.x-5.9 release

Triggering the testbot.

Status: Needs review » Needs work

The last submitted patch, 3: twitter-Update_API_documentation_for_hook_twitter_account_save-1895320-3.patch, failed testing.

Status: Needs work » Needs review

DamienMcKenna queued 3: twitter-Update_API_documentation_for_hook_twitter_account_save-1895320-3.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 3: twitter-Update_API_documentation_for_hook_twitter_account_save-1895320-3.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new twitter-n1895320-10.patch4.09 KB

Rerolled.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed to the 7.x-5.x branch.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-5.x-dev » 7.x-6.x-dev
StatusFileSize
new twitter-n1895320-12.patch552 bytes

This hook doesn't exist in the 7.x-6.x branch, but it's still mentioned in the API file.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-6.x-dev » 6.x-5.x-dev
Status: Fixed » Needs review
StatusFileSize
new twitter-n1895320-14.patch3.98 KB

Rerolled for the 6.x-5.x branch. This needs to be reviewed to confirm the docs are accurate.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #2402307: Plan for Twitter v7.x-5.9 release » #2402311: Plan for Twitter v6.x-5.2 release

Removing this from the 7.x release plans to avoid confusion.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#2402307: Plan for Twitter v7.x-5.9 release, +#2402309: Plan for Twitter v7.x-6.0 release

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.