Follow-up to #1416732: Offering to co-maintain Computed Field

It is currently not clear that you need to enable tmgmt_skills_module, otherwise tmgmt_local does not work at all, without indication as to why that is.

Maybe we should merge them together?

Possibly replace the plugin architecture with hooks.

CommentFileSizeAuthor
#1 skills-splitup-1895408-1.patch25.63 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Integrate the tmgmt_skills_module into tmgmt_local » Split tmgmt_skills into a field-type providing module and move the logic into tmgmt_local
Category: feature » task
Status: Active » Needs review
StatusFileSize
new skills-splitup-1895408-1.patch25.63 KB

Rename to tmgmt_language_combination and initial patch. Tests seem to pass, de-installation works ( you need to run crun between uninstalling tmgmt_local and tmgmt_language_combionation but it works).

Not yet sure about the capabilities API/hooks. What we're doing right now is insane (execute a query/hook for every user on your system with the necessary permission). I still have no clue why we'd want to have an alternative way to provide language capabilities. But that's a separate issue.

blueminds’s picture

blueminds commented

if removed tmgmt_local_languages_predefined_list() call works with hermes/tmgmt_server. However http://drupal.org/node/1895432 needs to get solved so that tmgmt_server and other translators can properly expose language skills.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks for testing, fixed that call (we discussed moving that to an alternative widget that is provided by the server as it only makes sense there, but that's something for another issue and needs to be changed in tmgmt_server first) and commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.