Hello,

If these indicators are exposed we could use them in Views and Search API.

CommentFileSizeAuthor
#6 office_hours_1895608.patch2.03 KBjohnv

Comments

johnv’s picture

johnv
Primary language Dutch
commented

Don't know how to do that. Can you provide a patch? Thanks.

giorgio79’s picture

giorgio79 commented
Status: Active » Postponed

Will try to poke around :)

johnv’s picture

johnv
Primary language Dutch
commented
Status: Postponed » Active
giorgio79’s picture

giorgio79 commented

Been researching this. Here is a cool example on how the range module did this #1872194: Add support for Search API

johnv’s picture

johnv
Primary language Dutch
commented

See also #1958176: Views D7 & Field cache for 'Currently Open/Closed' Status formatter ?

johnv’s picture

johnv
Primary language Dutch
commented
StatusFileSize
new office_hours_1895608.patch2.03 KB

A first attempt.

giorgio79’s picture

giorgio79 commented
Issue summary: View changes
Status: Active » Needs review

This looks real good. Will be checking it out soon.

Pls’s picture

Pls commented

WIll review patch this weekend. Looks good from first look. Thanks :)

Pls’s picture

Pls commented
Status: Needs review » Needs work

Manually applied the patch and it looks to be inactive. Indexed currentstatus field, but no values are returned by _office_hours_get_current_status, which looks to me not right for a purpose.

Not sure why this is declared as integer field. Maby it should be boolean, so that it would return TRUE when currently open, otherwise FALSE when not.

This patch seems to be almost identical to https://www.drupal.org/node/1872194#comment-6969684, which is for range filtering rather than getting status. This needs refactoring, I will try to get something going this month as we need this functionality on our project. Other patches are also welcome :)

johnv’s picture

johnv
Primary language Dutch
commented
Status: Needs work » Closed (outdated)

Given the life cycle of D7, this issue is considered closed. However, patches are appreciated.