Hi, I just installed the latest version and spent quite a while trying to work out why I couldn't get the taxonomy term options to appear in the menu item form. The cause appears to be that the entity type is 'taxonomy_term' but the token type is 'term'. This bug seems to have been caused by your refactoring to remove the type-specific plugins.
(I took a look at the original plugin in the hope that I could just drop it back into the plugins directory but the code doesn't seem to solve my problem, which is to be able to extract a taxonomy term from the url in a more general manner. Ideally I'd like panels integration, but that seems to be somewhat tricky.)
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | entity_token_type-1895628-2.patch | 3.97 KB | malberts |
| #1 | entity_token_type-1895628-1.patch | 4.09 KB | malberts |
Comments
Comment #1
malberts commentedChanged 2 things:
1. The original code assumes entity type = token type.
2. The context loader plugin assumes the entity path has this pattern: [something]/[entity_id]
I'm not 100% happy with (2) because I couldn't find any cleaner way to get the entity represented by the URL. However, they way I have it now it should work for things like "taxonomy/term/123" and also on a View page, for example "taxonomy/term/123/news".
I noticed that the beta version is newer than the dev version, however the patch applied cleanly locally on both dev and beta-5.
Comment #2
malberts commentedPrevious patch's URL sniffing died when editing menu links.
Comment #3
develcuy commentedCode looks great but I would like to see passing tests. Nice opportunity for somebody that would like to showcase their simpletest skills in a popular module ;)
Comment #4
develcuy commentedComment #5
develcuy commentedOK, nobody wants to write a patch... if the patch applies I'll commit it as is!
Comment #6
develcuy commentedThere you go @malberts!
Comment #7
develcuy commented