If you change the path structure for generated packages, the packager will save the files not in the default location.
But the links on the download page will be generated with the default structure.

CommentFileSizeAuthor
#6 1896090-5-l10n_packager_download_url.patch3.55 KBSebCorbin
#2 l10n_server-fixed_download_links-1896090-2.patch2.92 KBNBZ4live
#1 l10n_server-fixed_download_links-1896090.patch1.75 KBNBZ4live

Comments

NBZ4live’s picture

NBZ4live commented
StatusFileSize
new l10n_server-fixed_download_links-1896090.patch1.75 KB

Here is the patch. Now the File API is used to get the download url from the stream uri.

NBZ4live’s picture

NBZ4live commented
StatusFileSize
new l10n_server-fixed_download_links-1896090-2.patch2.92 KB

Here new patch. Forgot about the download table on the language view pages.

SebCorbin’s picture

SebCorbin commented
Status: Needs review » Needs work

For front-facing URI, we need to build the url according to the setting of "Root URL for translation downloads" in packaging settings.

This is used on localize.drupal.org to prefix urls with http://ftp.drupal.org/files/translations. I suggest we modify the behavior this way:
If root url is defined, build the url as before. If it's empty, use the file uri and file_create_url() function.

NBZ4live’s picture

NBZ4live commented

I would suggest to move the uri generation to a separate function.
I will make a new patch.

SebCorbin’s picture

SebCorbin commented
Title: [Patch] Failure in the format of the links on the download page » Correctly format links on the download page
Status: Needs work » Needs review

Here's a new patch (added hook_flush_caches so that cache can be unvalidated by admin)

SebCorbin’s picture

SebCorbin commented
StatusFileSize
new 1896090-5-l10n_packager_download_url.patch3.55 KB
SebCorbin’s picture

SebCorbin commented
Status: Needs review » Fixed

Committed as tests are green and tested manually

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.