It would be handy to allow global tokens in Ad Unit names and other areas.

* Brought global tokens into scope
* Fixed a few typos - Implements of hook_... -> Implements hook_...
* Fixed typo $tagets[] = check_plain($data['target']) . '=' . check_... -> $targets[] = check_plain($data['target']) . '=' . check_...

This patch also includes the patch from http://drupal.org/node/1895522.

CommentFileSizeAuthor
#5 1896188.patch2.88 KBbleen
#4 1896188-allow_the_use_of_global_tokens.patch4.7 KBsoulston
1866196-override-the-adunit-on-context-settings.patch2.77 KBsoulston

Comments

bleen’s picture

bleen commented 
+++ b/plugins/export_ui/dfp_ctools_export_ui.incundefined
@@ -108,7 +108,7 @@ function dfp_tag_form(&$form, &$form_state) {
+    '#global_types' => TRUE, // A boolean TRUE or FALSE whether to include 'global' context tokens like [current-user:*] or [site:*]. Defaults to TRUE.

if we are going to allow for global tokens we should allow them everywhere ... do a search for "#global_types" and you'll see that there are several more places to change this. Once thats done this is RTBC

bleen’s picture

bleen commented
Status: Needs review » Needs work
bleen’s picture

bleen commented

also .. if you could review #1895522: Node tokens do not get rewritten when used in the Ad Unit pattern ... Im ready to commit that too

soulston’s picture

soulston commented
Status: Needs work » Needs review
StatusFileSize
new 1896188-allow_the_use_of_global_tokens.patch4.7 KB

Added patch.

* Brought global tokens into scope
* Fixed a few typos - Implements of hook_... -> Implements hook_...
* Fixed typo $tagets[] = check_plain($data['target']) . '=' . check_... -> $targets[] = check_plain($data['target']) . '=' . check_...

bleen’s picture

bleen commented
StatusFileSize
new 1896188.patch2.88 KB

re-roling #4 .. if testbot is happy I will commit

bleen’s picture

bleen commented
Status: Needs review » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.