Show people "liked this" link not show users if users not upload avatar.
In file heartbeat/modules/heartbeat_plugins/includes/heartbeatflagplugin.inc, I found this:

$result = db_query("SELECT u.name, files.uri, f.uid FROM {file_managed} files INNER JOIN {users} u ON u.picture = files.fid INNER JOIN {flag_content} f ON f.uid = u.uid WHERE content_id = :uaid AND content_type = 'heartbeat_activity' ", array(':uaid' => $uaid));

Query above isn't select users if user haven't picture. How to fix this issue?

CommentFileSizeAuthor
#3 no_picture_people-1896256-1.patch996 bytesduynguyen
show liked this 1.png10.04 KBduynguyen
show liked this.png19.8 KBduynguyen

Comments

duynguyen’s picture

duynguyen commented

My solution is change INNER JOIN users and file_managed to LEFT JOIN

$result = db_query("SELECT u.name, files.uri, f.uid FROM {users} u LEFT JOIN {file_managed} files ON u.picture = files.fid INNER JOIN {flag_content} f ON f.uid = u.uid WHERE content_id = :uaid AND content_type = 'heartbeat_activity' ", array(':uaid' => $uaid));
thehong’s picture

thehong commented

Duy, you please provide patch.

duynguyen’s picture

duynguyen commented
Status: Active » Needs review
StatusFileSize
new no_picture_people-1896256-1.patch996 bytes

This my patch

duynguyen’s picture

duynguyen commented
Issue summary: View changes

updte description