If a badly formed string of resolutions is entered in the setup - e.g.
1400, 1024,878, 800,420 added spaces
or
1400,1024 878,800,420 missing comma

this causes problems as line 58 in adaptive_image.image.inc will take all characters ( including spaces ) between commas to form resolutions that make up the image URL
$derivative_uri = $path_parts['dirname'] . '/' . $resolution . '/' . $path_parts['basename'];

CommentFileSizeAuthor
#5 1896356-5-resolutions_field_validation.patch944 bytesn1k
#4 1896356-4-resolutions_field_validation.patch946 bytesn1k
#3 1896356-3-resolutions_field_validation.patch2.14 KBn1k
#1 1896356-resolutions_field_validation.patch986 bytesn1k

Comments

n1k’s picture

n1k commented
Status: Active » Needs review
StatusFileSize
new 1896356-resolutions_field_validation.patch986 bytes

Hi,

This patch should validate the input and show an error message if some commas are missing.

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented
Priority: Major » Normal
Status: Needs review » Needs work 
+++ b/adaptive_image.moduleundefined
@@ -142,6 +142,25 @@ function theme_adaptive_image_scale_summary($variables) {
+  $resolutions = $form['data']['resolutions']['#value'];
+  $resolutions = explode(',',$resolutions);

Can be combined into one line.
Adhere to the coding standards http://drupal.org/coding-standards#functcall

+++ b/adaptive_image.moduleundefined
@@ -142,6 +142,25 @@ function theme_adaptive_image_scale_summary($variables) {
+  foreach($resolutions as $r_width)

Please don't use abbreviations.

+++ b/adaptive_image.moduleundefined
@@ -142,6 +142,25 @@ function theme_adaptive_image_scale_summary($variables) {
+  foreach($resolutions as $r_width)
+  {

Adhere to the coding standards http://drupal.org/coding-standards#controlstruct

+++ b/adaptive_image.moduleundefined
@@ -142,6 +142,25 @@ function theme_adaptive_image_scale_summary($variables) {
+      form_set_error('Resolutions', t("Values have to be seperated by comma. For example: 1382, 992, 768, 480"));

The first parameter is the form elements name, so probably lower case.

All only minor things, please correct them for the patch to be committed.
Thanks.

n1k’s picture

n1k commented
Status: Needs work » Needs review
StatusFileSize
new 1896356-3-resolutions_field_validation.patch2.14 KB

Adjusted patch to coding standards.

n1k’s picture

n1k commented
StatusFileSize
new 1896356-4-resolutions_field_validation.patch946 bytes

Fixed file.

n1k’s picture

n1k commented
StatusFileSize
new 1896356-5-resolutions_field_validation.patch944 bytes

And fixed it again.

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented
Version: 7.x-1.4 » 7.x-1.x-dev
Status: Needs review » Fixed

Committed and pushed to 7.x-1.x.
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.