payment_form_embedded() is a 'semi form builder'. It only returns a set of form elements. To make it easier for developers to understand (do as core does) and to make altering the form elements more flexible, the function should be converted to a custom form element.

Postponed until 7.x-2.x.

CommentFileSizeAuthor
#6 payment_1896362_6.patch485 bytesxano
#4 payment_1896362_4.patch6.17 KBxano

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Version: 7.x-1.x-dev » 8.x-2.x-dev
Status: Postponed » Active
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Title: Convert payment_form_embedded() to a payment_form form element » Remove payment_form_embedded() and payment_form_standalone()

Instead, just remove both functions and let forms decide which payment_* form elements to use themselves. This makes customizing forms and data processing easier.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Title: Remove payment_form_embedded() and payment_form_standalone() » Remove payment.ui.inc

#2107979: Port the payment edit form is the last thing that still depends on code in payment.ui.inc.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Active » Fixed
StatusFileSize
new payment_1896362_4.patch6.17 KB
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Fixed » Active

payment.module still contains module_load_include('inc', 'payment', 'payment.ui');.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Active » Fixed
StatusFileSize
new payment_1896362_6.patch485 bytes

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jian he’s picture

jian he commented
Issue summary: View changes

I am trying to implement payment_ubercart to drupal 8. This patch removed the payment_form_embedded. And I could not found any document or change records for this.
My question is: How to implement the similar payment_form_embedded feature in Drupal 8?

jian he’s picture

jian he commented
Status: Closed (fixed) » Fixed
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Fixed » Closed (fixed)

Look at how Payment 8.x-2.x's submodules display payment forms. The correct approach depends on how Ubercart works, so it's not possible to give you a straight answer right now.

If you have more questions, please open new issues instead of reopening old ones.