Download & Extend
Drupal Commerce » Issues

Make the "Add a payment method rule" form a little easier

Posted by rszrama on January 23, 2013 at 3:33pm
Project:Drupal Commerce
Version:7.x-1.x-dev
Component:Payment
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:low-hanging fruit

Issue Summary

Specifically, by adding a select list for available payment methods and putting an action on the Rule to enable the specified payment method.

Login or register to post comments

Comments

#1

Posted by joshmiller on February 8, 2013 at 4:41pm

Attached is a patch that requires a user to select at least one payment method to enable and allows them to select more than one. Very proud of this one :) Thanks to Ryan for walking me through some of the more complicated bits.

AttachmentSizeStatusTest resultOperations
enablepaymentactions-1896690-1.patch3.45 KBIdlePASSED: [[SimpleTest]]: [MySQL] 3,570 pass(es).View details

#2

Posted by joshmiller on February 8, 2013 at 4:42pm
Status:active» needs review

#3

Posted by joshmiller on February 8, 2013 at 5:17pm

Needed some cleanup for the checklist to make sense.

AttachmentSizeStatusTest resultOperations
enablepaymentactions-1896690-3.patch3.33 KBIdlePASSED: [[SimpleTest]]: [MySQL] 3,570 pass(es).View details

#4

Posted by System Message on February 8, 2013 at 5:35pm
Status:needs review» needs work

The last submitted patch, enablepaymentactions-1896690-3.patch, failed testing.

#5

Posted by joshmiller on February 8, 2013 at 7:51pm
Status:needs work» needs review

MySQL wasn't available in the last test, thus the errors.

#6

Posted by joshmiller on February 8, 2013 at 7:51pm

#3: enablepaymentactions-1896690-3.patch queued for re-testing.

#7

Posted by JulienD on March 8, 2013 at 3:54pm
Status:needs review» reviewed & tested by the community

Hi

I've tested the patch and it's working as expected. When I create a new payment rule, I can select every payment method I need and when I submit the form, all the selected payments are put in the "action" section, ready to be enabled.

Thx Josh for the patch.

#8

Posted by rszrama on March 18, 2013 at 4:32pm
Status:reviewed & tested by the community» fixed

Tweaked this to only support enabling one payment method per rule due to the limitations of the current system.

Commit: http://drupalcode.org/project/commerce.git/commitdiff/b17da63

#9

Posted by System Message on April 1, 2013 at 4:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here