Replace "boolean" with "bool" when used as param/return/var type

Probably a good Novice project.

pcambra I am working on it ;)

Also replaced "@var boolean" declarations.

Attached complete patch. Hope it's right.

exclude 3rd party scripts ?

+++ b/core/vendor/doctrine/common/lib/Doctrine/Common/EventManager.phpundefined
--- a/core/vendor/doctrine/common/lib/Doctrine/Common/Lexer.php
+++ b/core/vendor/doctrine/common/lib/Doctrine/Common/Lexer.phpundefined

+++ b/core/vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/Request.phpundefined
--- a/core/vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/Resources/stubs/SessionHandlerInterface.php
+++ b/core/vendor/symfony/http-foundation/Symfony/Component/HttpFoundation/Resources/stubs/SessionHandlerInterface.phpundefined

Despite not living in core/vendor ArchiveTar is also an external file and should be excluded as well.

I understood that these type of patches that touch many files were not going to be committed until after the new feature deadline in February. Good to see this one being developed in anticipation.

It looks like you missed the '@var Boolean' in ..\Core\Database\Transaction.php. I did not see any others in a quick scan.b

As a follow up to this issue, other "basic" house-cleaning documentation issues like this one include:
- 'array' instead of 'Array' in @return, @param and @var directives,
- 'int' instead of 'integer' in @return, @param and @var directives,
- leading slash before these three directives for strings like '@param Drupal\' and '@param Symphony', and
- a global clean up of 'Contains ' replacing 'Definition of ' in the core class files.

Updating issue title

Let's leave this issue just for "boolean", and leave the issue title as it was. Separate issues can be filed for the other issues if necessary.

And yes, as mentioned above (sorry, forgot to think of this): Definitely don't touch any files with /vendor/ in their path, or ArchiveTar, which should be in /vendor/ but isn't (don't even ask).

A somewhat related issue is the use of the lower case term 'boolean' in the @param/return/var directive descriptions. According to #1431632-10: Clean up API docs for translation module, @xjm and @jhodgdon have previously stated that 'the word "Boolean" should always be capitalized (because it's derived from the name Boole).'

I am not sure whether this 'boolean' capitalization issue also should be dealt with in this issue or a follow-up issue.

Let's keep this issue targeted.

And you're probably right that this issue should be postponed until after feature freeze, when we'll enter the "cleanup" phase.

Related issue: #1860690: Correct Boolean use in docblocks

Hey what's up with all the changes I have done?

So if you want I could keep them in a branch and merge them later or maybe I could do something else.

If you want to make a patch that omits the vendor files and ArchiveTar, we can revive it or reroll it when it's time to un-postpone this issue in a few weeks. Thanks! And sorry about forgetting we aren't supposed to do massive cleanups before then...

Updated with #1897058-7: Replace "boolean" with "bool" when used as param/return/var type comment

Ill will be working on this issue during the Amsterdam 2014 Sprint.

patch only changing boolean/Boolean to bool in @param/@return/@var.

Hm. Above I think we decided not to fix the ArchiverTar class, which has many other problems beyond this one.

I'm also not sure about the JS files... let's just do PHP in this patch. I think in some cases Boolean is correct in JS.

The rest looks good. Can you just remove the JS and ArchiverTar parts from this patch? And thanks for reviving the issue!

made changes requested in #19.

Thanks, looks good!

Beta eval: This is docs only.

Docs are not frozen in beta. Committed 284681a and pushed to 8.0.x. Thanks!