Well done, it's about time someone builds this.

In Drupal6 comments behave the way that this module makes them behave. So, it would be great if your module provided an easy upgrade path into that Drupal6 world and clarified this situation on the project homepage.

Perhaps you are already aware of this, but people who find this project's homepage might not be - which is why I'm requesting this doc fix as well.

Comments

greggles’s picture

Just occurred to me that maybe your module still provides features beyond the Drupal6 version of signatures in which case it would be great to clarify what those differences are.

liam mcdermott’s picture

Version: » 5.x-1.x-dev
Assigned: Unassigned » liam mcdermott

Just occurred to me that maybe your module still provides features beyond the Drupal6 version of signatures in which case it would be great to clarify what those differences are.

Good point, the biggest difference is using mediumtext as the signature field, the users table has a signature field size of varchar(255). The uninstall moves all data back into the user table if this module is uninstalled, so it shouldn't be difficult to move signatures back into core.

This module is a fork of the signature module (that seems to be dead, unfortunately I wasn't able to become the maintainer or get a patches committed).

liam mcdermott’s picture

Status: Active » Postponed (maintainer needs more info)

I've updated the project home page's description. Would you mind having a quick look and letting me know if it's better?

Thanks. :)

greggles’s picture

Looks great. One thing though - if you want you can take-over the signature project. Just post an issue offering help and/or to take over the module. Mark it critical. If we wait two weeks and the maintainer doesn't respond then I (or another site admin) can make you the maintainer of that module.

Cheers.

liam mcdermott’s picture

One thing though - if you want you can take-over the signature project. Just post an issue offering help and/or to take over the module.

Ah, well now. There's a problem with that. I did raise an issue, and sent the chap an e-mail, as you can see he wrote quite a reasonable response.

The problem is: the maintainer hasn't committed any code to that project since taking it over, there has been a patch sat in the queue for 26 weeks too. After consulting with Michelle in #drupal-support we decided to wait a week, to see if anything was done with the submitted patches. Nothing happened, so the project was forked. I'll gladly merge the two together again, as long as the project is going to be maintained.

There was also some urgency as the vBulletin to Drupal module depends upon this one. Not being able to get changes committed to the signature module was holding up the vBulletin one too.

Does that course of events make sense? Am worried about DoingTheRightThing(tm). :)

greggles’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

Makes total sense. I've followed up in that issue.

I think we can close this.