Patch for Production module

Hi grzegorz.bartman,

Thanks very much for letting us know about this particular issue.
This is just a quick reply to let you know your request has been well received and we will try to get back to you on this as soon as possible.

I haven't had the time to test the patch yet, but will certainly look into this and get back to you with a review.

Thanks again very much for your interest and help reporting issues, it is highly appreciated.
Cheers!

Hi grzegorz.bartman,

Thanks very much for your interest in this module and submitting these patch files.

I apologize for the delay of this answer, but I was finally able to take a closer look at the submitted files and the Production module.

I'm not so sure exactly what you would like to achieve here, but correct me if I'm wrong, it seems you would like to:
Disable email rerouting (set REROUTE_EMAIL_ENABLE to FALSE) when production is active is enabled (production_is_active() returns TRUE).

Would there be any particular reason why this couldn't be done from the Production module itself?

The patches currently as they are, present a major usability problem, as follows:

There is no particular information or nothing that could let users know that the Reroute Email settings have been overriden because the site is under production active mode.
Take for example a colleague working on the same project as you with the Production and Reroute Email modules enabled, who doesn't know that the Production configuration has been set to active and browse to the Reroute Email settings page. They wouldn't understand (or spend more time to understand) why any change in the Reroute Email configuration wouldn't change anything (wouldn't work, it would be confusing).

In order to keep this topic more focused, I have listed my ideas with patches in Production module's tracker as a feature request, see: #1908752: Another approach to disable email rerouting
and indirectly related: #1908636: Suggestions for code improvements..

I guess it would perhaps be better initially to explore possible options to reach the expected goal in the Production module directly without necessarily requiring changes to be made in any other modules.

I'm setting this post to postponed (maintainer needs more info) for now, since we would like to hear your opinion on the mentioned issues, in particular #1908752: Another approach to disable email rerouting.
We could then later get back to the Reroute email module and see if it would still be necessary to have these patches applied.
Feel free to change the status again to active or needs review, at anytime, if you feel like we should get our focus back on these patch files.

Please let me know if you would have any objections, questions, comments, recommendations, suggestions or concerns on any points/aspects of my answer or the related issues, I would surely be glad to explain in more details.

Any feedback, comments, testing, reporting or questions would be highly appreciated.
Thanks very much in advance.
Cheers!

Obviously, this is not going to be implemented in the module for now.
More issues have been stacking up in module's tracker and it would be good to take some off our stack.

Therefore, I allowed myself to mark this issue as Closed (won't fix) for now, but feel free to re-open it, or post a new ticket, at any time if you have any further objections with this issue or the solution suggested at #1908752: Another approach to disable email rerouting (we would surely be happy to hear your feedback).

Please let me know if you would have any further comments, feedback, questions, issues, objections, suggestions or concerns on this ticket in general, I would be glad to provide more information or explain in more details.

Thanks again to everyone for your testing, reviews, feedback and comments on this issue.
Cheers!