Posted by danbohea on January 24, 2013 at 11:05pm
4 followers
| Project: | Wysiwyg |
| Version: | 7.x-2.x-dev |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
See attached screens.
| Attachment | Size |
|---|---|
| Before maximising.png | 48.24 KB |
| After maximising.png | 17.99 KB |
Comments
#1
This appears to happen only when the Overlay is used. We've already got the logic in place to hide the standard Toolbar for editors which supports fullscreen modes, so this patch simply adds
#admin-menuto the list of elements to show/hide.#2
That patch seems to fix the issue for me. Many thanks.
#3
Looks good.
As a possible follow-up improvement (in a separate issue), we could investigate to provide central API helper methods for this, in order to decrease the amount of duplicated code.
#4
Thanks for the quick review, sorry it took me a month to patch this.
I've committed this to all major branches and the -dev snapshots will be updated within 12 hours and this will be part of the next official releases..
EDIT: Yes, a central utility function sounds good.
Follow-up in #1927000: Add utility functions for fullscreen mode management.
#5
Automatically closed -- issue fixed for 2 weeks with no activity.