Hi guys,

Thank you so much for this great module, in particular the latest commits for Drupal 7 and added features are excellent.

It seems that during the patching and discussion process, support for the Libraries API module has been added (See #1579380-16: Add support for All cloud zoom settings, and Gallery mode.) which is great but added a requirement for this module, as mentioned on the project page:

3. Enable the module (and dependencies, such as libraries (2.x) and core Image module.

I recently encountered this issue while going through this installation process without reading anything on the project page:
I didn't enable the Libraries API module and therefore nothing happened.

I checked and indeed, there is no explicit dependency declared in the cloud_zoom.info file for the Libraries API module.

This may sound as something minor, but I was wondering if you would consider at any point adding a dependency to the Libraries API module which would prevent having incautious users (like me) going through the installation process very quickly without errors and spending time checking why the Javascript is not showing up (then getting back to project page, to follow the standard installation procedure), even though the necessary JS code would be in the correct/appropriate folders.
I guess this wouldn't have happened if I weren't able to enable the module without Libraries API installed or in modules' folder, and the installation process would have gone smoothly.

We could simply add to cloud_zoom.info the following code:

dependencies[] = libraries (>2.x)

The part about the specific version requirements (>2.x) would be optional, I assume, since it might work as well with earlier versions (I have only tested with libraries-2.x, though).

Please find attached to this ticket the patch for adding the dependency to the Libraries API, against latest module version cloud_zoom-7.x-1.1+1-dev (2012-10-17):
cloud_zoom-missing-dependency-libraries-0.patch

Since I'm not entirely sure if there was any particular reason this dependency was not added, I posted this ticket as a support request and not a bug report.
However, I would personally assume it would be a small bug of the module, since it seems now to heavily rely on Libraries API's hooks.

I would greatly appreciate to have your feedback and opinion on this particular issue, since I think it could potentially be resolved very quickly and easily.
Please let me know if you would have any questions, comments or concerns on any points/aspects mentioned in this ticket, I would surely be glad to provide more information.

Any feedback, comments, testing, questions, recommendations or suggestions would be highly appreciated.
Thanks very much in advance.

CommentFileSizeAuthor
cloud_zoom-missing-dependency-libraries-0.patch311 bytesdydave

Comments

alfababy’s picture

alfababy commented

Great, you are very carefully.

ycshen’s picture

ycshen commented

I agree with you.
I think if user enable this module and doesn't enable libaries.and see this module doesn't work,he will confuse.
the dependencies is necessary.

lsolesen’s picture

lsolesen commented
Status: Active » Needs review
vbouchet’s picture

vbouchet
Location Toulouse
commented
Status: Needs review » Reviewed & tested by the community

This dependency is required to use this module.

msti’s picture

msti
Location Heraklion
commented

I have created this github repo that fixes this and other issues until the maintainer finds time to update it.
https://github.com/msti/cloud-zoom-drupal

dimmech’s picture

dimmech commented

@msti Could you please submit your fixes as patches in the issue queues of the items they resolve?

  • dakku committed f88b8b7 on 7.x-1.x authored by DYdave 
    Issue #1898514 by DYdave: Missing dependency for libraries?
dakku’s picture

dakku commented
Status: Reviewed & tested by the community » Fixed
dydave’s picture

dydave commented

Thanks very much @dakku for committing this patch and crediting me on this issue, even after such a long time.
It's highly appreciated.

I'm hoping this will help further improving and stabilizing the Cloud Zoom module.

Thanks a lot to everyone for your testing, reporting and feedback.
Cheers!

dakku’s picture

dakku commented

@DYdave. Thank you for your work, its taken a while to commit but better late than never as they say..

I started a Drupal 8 port of this module over at:
https://github.com/dakkusingh/cloud_zoom

Would be awesome if you want to collaborate. I have a work in progress branch currently underway.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.