Download & Extend
Issues

No test coverage for hook_editor_js_settings_alter()

Posted by Wim Leers on January 25, 2013 at 1:37pm
Project:Drupal core
Version:8.x-dev
Component:editor.module
Category:bug report
Priority:normal
Assigned:Wim Leers
Status:closed (fixed)
Issue tags:CKEditor in core, Spark, wysiwyg

Issue Summary

Title says it all. While working on something else, I discovered that it's even passing in a non-existing variable…

Login or register to post comments

Comments

#1

Posted by Wim Leers on January 25, 2013 at 1:38pm
Status:active» needs review
AttachmentSizeStatusTest resultOperations
hook_editor_js_settings_alter_tests-1898844-1.patch3.22 KBIdlePASSED: [[SimpleTest]]: [MySQL] 49,742 pass(es).View details

#2

Posted by Wim Leers on January 25, 2013 at 1:39pm

#3

Posted by Gábor Hojtsy on February 8, 2013 at 12:09pm

#1: hook_editor_js_settings_alter_tests-1898844-1.patch queued for re-testing.

#4

Posted by Gábor Hojtsy on February 8, 2013 at 12:10pm
Status:needs review» reviewed & tested by the community

The test looks good, it properly isolates the tested change so it does not happen for other cases. If it comes back green it should be committed :) Marking RTBC for that. (Retesting since it was developed 2 weeks ago).

#5

Posted by System Message on February 8, 2013 at 12:58pm
Status:reviewed & tested by the community» needs work

The last submitted patch, hook_editor_js_settings_alter_tests-1898844-1.patch, failed testing.

#6

Posted by Wim Leers on February 8, 2013 at 1:20pm
Status:needs work» needs review

#1: hook_editor_js_settings_alter_tests-1898844-1.patch queued for re-testing.

#7

Posted by System Message on February 8, 2013 at 2:08pm
Status:needs review» needs work

The last submitted patch, hook_editor_js_settings_alter_tests-1898844-1.patch, failed testing.

#8

Posted by Gábor Hojtsy on February 8, 2013 at 2:13pm

OpenIDAuthmapUpgradePathTest not related.

#9

Posted by Gábor Hojtsy on February 8, 2013 at 2:21pm
Status:needs work» needs review

#1: hook_editor_js_settings_alter_tests-1898844-1.patch queued for re-testing.

#10

Posted by System Message on February 8, 2013 at 3:59pm
Status:needs review» needs work

The last submitted patch, hook_editor_js_settings_alter_tests-1898844-1.patch, failed testing.

#11

Posted by Wim Leers on February 8, 2013 at 9:36pm
Status:needs work» needs review

#1: hook_editor_js_settings_alter_tests-1898844-1.patch queued for re-testing.

#12

Posted by Wim Leers on February 8, 2013 at 11:49pm
Status:needs review» reviewed & tested by the community

Back to RTBC per #4.

#13

Posted by webchick on February 9, 2013 at 11:48am
Status:reviewed & tested by the community» fixed

Oops. :) Thanks for the additional test coverage.

Committed and pushed to 8.x. Thanks!

#14

Posted by System Message on February 23, 2013 at 11:50am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.