Title says it all. While working on something else, I discovered that it's even passing in a non-existing variable…

CommentFileSizeAuthor
#1 hook_editor_js_settings_alter_tests-1898844-1.patch3.22 KBwim leers

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new hook_editor_js_settings_alter_tests-1898844-1.patch3.22 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +wysiwyg, +Spark, +CKEditor in core
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

#1: hook_editor_js_settings_alter_tests-1898844-1.patch queued for re-testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

The test looks good, it properly isolates the tested change so it does not happen for other cases. If it comes back green it should be committed :) Marking RTBC for that. (Retesting since it was developed 2 weeks ago).

Status: Reviewed & tested by the community » Needs work
Issue tags: -wysiwyg, -Spark, -CKEditor in core

The last submitted patch, hook_editor_js_settings_alter_tests-1898844-1.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review

#1: hook_editor_js_settings_alter_tests-1898844-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +wysiwyg, +Spark, +CKEditor in core

The last submitted patch, hook_editor_js_settings_alter_tests-1898844-1.patch, failed testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

OpenIDAuthmapUpgradePathTest not related.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Needs review
Issue tags: -wysiwyg, -Spark, -CKEditor in core

#1: hook_editor_js_settings_alter_tests-1898844-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, hook_editor_js_settings_alter_tests-1898844-1.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
Issue tags: +wysiwyg, +Spark, +CKEditor in core

#1: hook_editor_js_settings_alter_tests-1898844-1.patch queued for re-testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC per #4.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Oops. :) Thanks for the additional test coverage.

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.