A clean up for various stark twig errors.

CommentFileSizeAuthor
#5 twig_sandbox-1898956-5.patch1 KBc4rl
#1 stark_twig_error_msg.1898956.1.patch2.45 KBalexrayu

Comments

alexrayu’s picture

alexrayu commented
StatusFileSize
new stark_twig_error_msg.1898956.1.patch2.45 KB
alexrayu’s picture

alexrayu commented
Status: Needs review » Closed (works as designed)
alexrayu’s picture

alexrayu commented
Status: Closed (works as designed) » Needs review

Closed by mistake. Still needs review.

c4rl’s picture

c4rl commented
Title: Stark twig errors clean up » html.html.twig errors clean up
Status: Needs review » Needs work

Some of these have already been fixed on the fly.

It appears the only outstanding ones are left in html.html.twig

c4rl’s picture

c4rl commented
StatusFileSize
new twig_sandbox-1898956-5.patch1 KB

So it appears these are the only residual changes?

The question, for me, is whether we need these conditionals in the template at all. That is, shouldn't the preprocessor handle these as empty strings?

alexrayu’s picture

alexrayu commented

Would be handy if preprocessor handled that. No reason why it shouldn't.

alexrayu’s picture

alexrayu commented
Status: Needs work » Fixed

The issue seems to have been fixed. I have looked at handling empty items - it appears to be a twig issue. If we want to pursue it lets have it a separate issue. This one seems to have been complete.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 1750250)