Just came across this. I think this could apply to this module. See https://twitter.com/davereid/status/294554866649542657 for more details.

CommentFileSizeAuthor
#1 extlink-use-hook_page_build-1899000.patch473 bytesgmclelland

Comments

gmclelland’s picture

gmclelland commented
Status: Active » Needs review
StatusFileSize
new extlink-use-hook_page_build-1899000.patch473 bytes

and here is the patch

elachlan’s picture

elachlan commented

+1 would improve performance.

Also patch looks good.

elachlan’s picture

elachlan commented
Status: Needs review » Fixed

Committed to Git.

gmclelland’s picture

gmclelland commented

Great!, I'm assuming this was committed to the master branch? How about creating a 7.x-1.x-dev release with a 7.x-1.x branch?

elachlan’s picture

elachlan commented
Status: Fixed » Closed (fixed)
roball’s picture

roball commented
Status: Closed (fixed) » Active

Why did you also commit to the 6.x-1.x branch? This did completely break the module - see here: #2054433: hook_page_build() used - Drupal 6 does not have this hook

elachlan’s picture

elachlan commented
Status: Active » Closed (fixed)