Permission for workflow state change on node edit form broken [#1899262]

Removing the permission "change workflow state via node edit form" from a role doesn't actually remove the workflow fieldset from the node edit or creation form.

Comment	File	Size	Author
#1	workflow_extensions-node_edit_permission-1899262-0.patch	623 bytes	dbassendine

Comments

Comment #1

dbassendine commented 25 January 2013 at 21:07

Status	File	Size
new	workflow_extensions-node_edit_permission-1899262-0.patch	623 bytes

This is because in "workflow_extensions_form_alter", line 188 the code checks for ['#form-id'] = 'node-form'.

 // 2) Suppress Workflow fieldset on the create/edit form if not permitted.
  if (isset($form['#id']) && $form['#id'] == 'node-form' && !user_access('change workflow state via node edit form')) {
    unset($form['workflow']);
    return;
  }

The proper check is for isset($form['#node_edit_form']). I've attached a patch to correct this (against 7.x-1.0-alpha1).