When generating tags for Emails, using the "Render this tag without Javascript" checkbox, the actual tags generated dont render correctly.

What's Generated is:

<a href="http://pubads.g.doubleclick.net/gampad/jump?iu=[adUnitName]&c=100000&size=234x60&tile=1">
<img src="http://pubads.g.doubleclick.net/gampad/ad?iu=[adUnitName]&c=100000&size=234x60&tile=1"/>
</a>

With a little URL Fiddling I can get the ad to render with

  1. adding my network id before the adUnitName
  2. removing the "tile" parameter
<a href="http://pubads.g.doubleclick.net/gampad/jump?iu=/[NetworkID]/[AdUnitName]&c=100000&size=234x60&tile=1">
<img src="http://pubads.g.doubleclick.net/gampad/ad?iu==/[NetworkID]/[AdUnitName]&c=100000&size=234x60&tile=1"/>
</a>

An Additional Feature Request, would be to also incorporate the "Global Targeting" parameters into the Non Javascript tags.

IGM

CommentFileSizeAuthor
#6 dfp-fix_non_java_tag-1899302-4.patch1.32 KBIGM

Comments

IGM’s picture

Forgot to remove the tile parameter in my "working url" example.
And note one other change required, the size parameter is should be "sz"

<a href="http://pubads.g.doubleclick.net/gampad/jump?iu=/[NetworkID]/[AdUnitName]&c=100000&sz=234x60"><img src="http://pubads.g.doubleclick.net/gampad/ad?iu==/[NetworkID]/[AdUnitName]&c=100000&sz=234x60"/></a>

IGM

bleen’s picture

can you point me to some documentation from Google that outlines these changes? I've never heard that size should be sz or that tile should not be included. As for the networkID, I need to take a closer look, but that should be included already. Hmmmm

IGM’s picture

Thanks for the response.

below is the guidance google gives on creating non-java-script tags and their parameters.
http://support.google.com/dfp_premium/bin/answer.py?hl=en&answer=1638620

Note the Size Parameter is "sz"

Regarding the "tile" parameter, in my implementation I do not have multiple tags using the same ad unit name, perhaps that is the issue. But, certainly when I add the tile parameter back into the url the ad fails to render.

IGM’s picture

After downloading the latest version of this...

I have confirmed that the ads will display with the "Tile" parameter in the string. Apologies if I didn't troubleshoot this correctly in the first place.

Ads will display now if the following changes are made to the dfp.module.

Line 775
- $keyvals['iu'] = $tag->adunit;
+ $keyvals['iu'] = token_replace('[dfp_tag:network_id]/' . $tag->adunit, _dfp_prepare_tokens($tag));

Line 777
- $keyvals['size'] = str_replace(',', '|', check_plain($tag->raw->size));
+ $keyvals['sz'] = str_replace(',', '|', check_plain($tag->raw->size));

rechecked if you dont change Size to SZ no ad renders and link is broken.

IGM

bleen’s picture

Would you mind submitting a patch?

IGM’s picture

StatusFileSize
new1.32 KB

This worked on my installation...

bleen’s picture

Status: Active » Needs review

setting to "needs review" so that testbot will run automated tests

bleen’s picture

Status: Needs review » Fixed

committed to 7.x-1.x-dev... thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.