Though the module does not declare panopoly_core as a dependency, it cannot be used without the core.

It seems to use CSS/layouts for the IPE settings, and also a call to panopoly_core_view_mode_options() returns an AJAX error with panopoly_core disabled.

It would be nice if one could use this part of panopoly without the core (and its huge list of dependencies), but another "fix" would be to just declare panopoly_core module as a dependency of panopoly_magic.

CommentFileSizeAuthor
#3 panopoly_magic-without-core-1899368-3.patch24.78 KBsaltednut
#1 panopoply_magic-without-core-1899368-1.patch5.85 KBsaltednut

Comments

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
StatusFileSize
new panopoply_magic-without-core-1899368-1.patch5.85 KB

Patch Description

Some bits from panopoply_core inserted into panopoply_magic that should enable builders to use the module without the extra baggage.

Motivation

Use panopoly_magic to allow users to modify views within panels ipe. Do so without bringing along the following extra dependencies: views_autocomplete_filters, pm_existing_pages, token, pathauto, panels_breadcrumbs, panelizer, libraries, fieldable_panels_panes, field_group, entityreference, context, defaultcontent, defaultconfig, date_views, date_popup, date_api, date, apps

Additional Notes

  • Yes, many of these will likely make it into projects - but they don't NEED to be there to make panopoply_magic work.
  • For our specific purpose, losing the defaultcontent and defaultconfig dependencies is a big deal.
saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Category: bug » feature
Issue tags: +demo_framework
saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
StatusFileSize
new panopoly_magic-without-core-1899368-3.patch24.78 KB

Looks like the first patch was built wrong. I also removed d.o. packaging info and fixed a rather silly spelling error. :)

populist’s picture

populist commented
Project: Panopoly Magic » Panopoly
populist’s picture

populist commented
Title: Module does not work without panopoly_core » Allow Panopoly Magic to Work Without Panopoly Core
Status: Active » Postponed

Good direction. I changed the title to reflect more of what is being asked for and postponed since this isn't a super high priority.

populist’s picture

populist commented
Status: Postponed » Active

Adding this back to the active queue since this should be doable for RC4.

wbobeirne’s picture

wbobeirne commented
Status: Active » Reviewed & tested by the community

Fantastic patch, was in the middle of doing this myself before I thought to check here. Now, to do the same for panopoly widgets...

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented

@wboberine I have a patch for widgets too. #1949710: Use Panopoly Widgets in Demo Framework

populist’s picture

populist commented
Status: Reviewed & tested by the community » Fixed

Sounds great. Just reviewed + committed. Also removed the CSS file from Panopoly Core for completeness.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented

Nice! http://drupal.org/node/1645576/commits Looks like the authorship got borked but whatevs - just glad this is finally in! w0000t

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Issue tags: -demo_framework

Removing tags as this patch is no longer needed for the Demo Framework.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.