Should be trivial as there no typed data changes involved, just define the field item class and tests. Sub-task of #1732730: [meta] Implement the new entity field API for all field types

CommentFileSizeAuthor
#10 telephone-item-1899378-10.patch4.33 KBberdir
#10 telephone-item-1899378-10-interdiff.txt670 bytesberdir
#8 telephone-item-1899378-8.patch4.33 KBberdir
#1 telephone-item-1899378-1-for-testbot.patch18.43 KBberdir
#1 telephone-item-1899378-1.patch4.32 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new telephone-item-1899378-1.patch4.32 KB
new telephone-item-1899378-1-for-testbot.patch18.43 KB

Nothing special to see here :)

Status: Needs review » Needs work

The last submitted patch, telephone-item-1899378-1.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
das-peter’s picture

das-peter commented

Visual review looks good, didn't actually test it. I think I found only some nitpicky stuff:

+++ b/core/modules/telephone/lib/Drupal/telephone/Tests/TelephoneItemTest.php
@@ -0,0 +1,84 @@
+    // Create an field field and instance for validation.

// Create a telephone field and instance for validation

+++ b/core/modules/telephone/lib/Drupal/telephone/Tests/TelephoneItemTest.php
@@ -0,0 +1,84 @@
+   * Tests using entity fields of the field field type.

+ * Tests using entity fields of the telephone field type.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Issue tags: -Entity Field API

#1: telephone-item-1899378-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, telephone-item-1899378-1.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
Issue tags: +Entity Field API

#1: telephone-item-1899378-1.patch queued for re-testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new telephone-item-1899378-8.patch4.33 KB

Thanks for the review, too much copy & paste. Should be better now.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work

Still, one nit-pick left:

+++ b/core/modules/telephone/lib/Drupal/telephone/Tests/TelephoneItemTest.php
@@ -0,0 +1,84 @@
+    // Create an telephone field and instance for validation.

a telephone field

Except from that, this is RTBC.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new telephone-item-1899378-10-interdiff.txt670 bytes
new telephone-item-1899378-10.patch4.33 KB

Fixed that.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.