The dependency on the 'update' module is unnecessary for day-to-day operation of apps-enabled Drupal sites, as installation and updates typically only occur infrequently on a production site after adequate testing. It is a reasonably common practice to disable 'update' on production sites in order to avoid unnecessary available updates error messages and reduce cron processing time.
I propose that apps.installer and apps.updater are moved into a secondary module to separate management tasks from installation/upgrade tasks.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 1899390-remove-update-dep-2.patch | 6.02 KB | beeradb |
| #2 | 1899390-remove-update-dep.patch | 7.79 KB | beeradb |
Comments
Comment #1
joelcollinsdc commentedI agree that a dependency on update is unfortunate; especially for distributions where apps is most likely to be used, the update module is a distraction since most updates are probably going ot be distrubution updates, not module-by-module.
Comment #2
beeradb commentedComment #3
mrP commentednice!
+1 RTBC
Comment #4
beeradb commentedComment #5
beeradb commentedI was a bit overzealous with skipping install steps initially :) This latest patch installs fine for me, and I can't find any places where apps.module is not working correctly. Eventually we'll probably want to add an access check to the "admin/apps/%apps_server/update" menu path, but that page is currently just a "CURRENTLY UNDER DEVELOPMENT" message, so I think we can skip it for now.
Comment #6
beeradb commentedComment #7
beeradb commentedAlso there are a lot of whitespace changes in the file, which are all just trimming trailing whitespace (editor automatically does it). I can re-roll without those changes if necessary.
Comment #8
hefox commentedPerhaps a simplier root would be checking for update module and disabling certian functionality if it's not enabled?