function _voting_actions_compare($left, $op, $right, $default = TRUE) {
if (empty($left) || empty($default)) {
return $default;
}

must be replaced with

function _voting_actions_compare($left, $op, $right, $default = FALSE) {
if (!isset($left) || !isset($right)) {
return $default;
}

in case of condition, for example, $node->promote == 1
current code will always return true

Comments

FatPitchFinancials’s picture

FatPitchFinancials commented

Thank you for this bug fix. It worked nicely to solve a problem I was having when the first vote for a node was +1 and the second was -1, the node would get unpublished even though I set the voting action to unpublish when the node point was < -1.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Active » Closed (won't fix)

This version of Voting Actions is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.