Notice: Use of undefined constant DEBUG_BACKTRACE_IGNORE_ARGS - assumed 'DEBUG_BACKTRACE_IGNORE_ARGS' in _menu_token_is_called_from_features() (line 186 of /var/www/default/internships/dev/sites/all/modules/menu_token/menu_token.module).

CommentFileSizeAuthor
#12 menu_token-undefined_constant_notice-1899696-12.patch1.04 KBa.ross
#5 menu_token-undefined_constant_notice-1899696-5.patch734 bytesa.ross
#1 1899696.patch572 bytesrogical

Comments

rogical’s picture

rogical commented
Status: Active » Needs review
StatusFileSize
new 1899696.patch572 bytes

Please review, btw #1413800: Undefined context notices when using PHP < 5.3.6

rogical’s picture

rogical commented
Version: 7.x-1.0-beta4 » 7.x-1.x-dev
basvredeling’s picture

basvredeling
Primary language Dutch
Location Amsterdam
commented

Works, is a simple patch. But does this mean the links are altered even if they're called from menu_links_features_export_render?

perhaps something like this would be better: 

if (!isset($called)) {
    $callstack = defined('DEBUG_BACKTRACE_IGNORE_ARGS') ? debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS) : debug_backtrace(FALSE);
}
a.ross’s picture

a.ross commented

Problem caused by features integration (again). See #1289302: Features Integration

a.ross’s picture

a.ross commented
StatusFileSize
new menu_token-undefined_constant_notice-1899696-5.patch734 bytes

The patch in #1 isn't correct either, though it may prevent the notice.

johnpitcairn’s picture

johnpitcairn commented

Aargh. Patch at #5 works for me.

infines’s picture

infines commented

Works

basvredeling’s picture

basvredeling
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Reviewed & tested by the community

I can confirm the patch from #5 works.

geraldito’s picture

geraldito commented

Also confirm that patch from #5 works.

microniko’s picture

microniko commented

Patch from #5 works also for me !
Thks !!

a.ross’s picture

a.ross commented

You're welcome.

I just hope this gets committed soon. This has taken long enough already for something so simple.

a.ross’s picture

a.ross commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new menu_token-undefined_constant_notice-1899696-12.patch1.04 KB

Had an idea to prevent the awkward debug_backtrace() call altogether. That's easy at least when the features module isn't installed.

Patch

a.ross’s picture

a.ross commented
Status: Needs review » Fixed

Committed to 7.x-1.x

basvredeling’s picture

basvredeling
Primary language Dutch
Location Amsterdam
commented

Thanks for committing. I like your #12 implementation better than previous patches.

daganray’s picture

daganray commented

How do I apply this patch? Never mind, my php editor (Aptana Studio) did the job.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.