Download & Extend
Menu token » Issues

undefined constant DEBUG_BACKTRACE_IGNORE_ARGS

Posted by rogical on January 26, 2013 at 3:39pm
Project:Menu token
Version:7.x-1.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Notice: Use of undefined constant DEBUG_BACKTRACE_IGNORE_ARGS - assumed 'DEBUG_BACKTRACE_IGNORE_ARGS' in _menu_token_is_called_from_features() (line 186 of /var/www/default/internships/dev/sites/all/modules/menu_token/menu_token.module).

Login or register to post comments

Comments

#1

Posted by rogical on January 26, 2013 at 3:53pm
Status:active» needs review

Please review, btw #1413800: Undefined context notices when using PHP < 5.3.6

AttachmentSize
1899696.patch 572 bytes

#2

Posted by rogical on January 26, 2013 at 3:53pm
Version:7.x-1.0-beta4» 7.x-1.x-dev

#3

Posted by basvredeling on January 27, 2013 at 1:59pm

Works, is a simple patch. But does this mean the links are altered even if they're called from menu_links_features_export_render?

perhaps something like this would be better:

<?php
if (!isset($called)) {
    $callstack = defined('DEBUG_BACKTRACE_IGNORE_ARGS') ? debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS) : debug_backtrace(FALSE);
}
?>

#4

Posted by a.ross on January 28, 2013 at 3:29pm

Problem caused by features integration (again). See #1289302: Features Integration

#5

Posted by a.ross on January 28, 2013 at 4:05pm

The patch in #1 isn't correct either, though it may prevent the notice.

AttachmentSize
menu_token-undefined_constant_notice-1899696-5.patch 734 bytes

#6

Posted by John Pitcairn on January 29, 2013 at 11:54pm

Aargh. Patch at #5 works for me.

#7

Posted by gridbitlabs on January 30, 2013 at 6:03pm
Status:needs review» reviewed & tested by the community

Works

#8

Posted by basvredeling on January 30, 2013 at 5:48pm

I can confirm the patch from #5 works.

#9

Posted by geraldito on January 30, 2013 at 10:08pm

Also confirm that patch from #5 works.

#10

Posted by microniko on January 31, 2013 at 8:36pm

Patch from #5 works also for me !
Thks !!

#11

Posted by a.ross on February 4, 2013 at 12:42pm

You're welcome.

I just hope this gets committed soon. This has taken long enough already for something so simple.

#12

Posted by a.ross on February 4, 2013 at 4:45pm
Status:reviewed & tested by the community» needs review

Had an idea to prevent the awkward debug_backtrace() call altogether. That's easy at least when the features module isn't installed.

Patch

AttachmentSize
menu_token-undefined_constant_notice-1899696-12.patch 1.04 KB

#13

Posted by a.ross on February 8, 2013 at 9:28am
Status:needs review» fixed

Committed to 7.x-1.x

#14

Posted by basvredeling on February 8, 2013 at 12:00pm

Thanks for committing. I like your #12 implementation better than previous patches.

#15

Posted by daganray on February 22, 2013 at 2:57am

How do I apply this patch? Never mind, my php editor (Aptana Studio) did the job.

#16

Posted by System Message on March 8, 2013 at 3:00am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here