I think this module is a wonderful job! I must give you congratulations, for the job. But I found a bug or a misprint installing it. When I access to the database administration through "administration >> database" ... Shows some errors from tables that the module can't found, using "mysqli". Tracking the error throught the code I realized that there is no database type checking process for "mysqli" when retrieving tables from the database.

May be a misprint?

Line: 1475
File: dba.module

function _is_mysql() {
  return ($GLOBALS['db_type'] == 'mysql') ? 1 : 0;
}

I think It should be

function _is_mysql() {
  return ($GLOBALS['db_type'] == 'mysql' || $GLOBALS['db_type'] == 'mysqli') ? 1 : 0;
}

Regards!

Comments

dww’s picture

Status: Active » Closed (duplicate)

No, it wasn't a misprint, but code that pre-dated mysqli. ;) And it's already fixed: http://drupal.org/node/154813

sumeg26’s picture