Closed (fixed)
Project:
Commerce PayPal
Version:
7.x-2.x-dev
Component:
PayPal EC
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
27 Jan 2013 at 03:28 UTC
Updated:
13 Jul 2013 at 03:51 UTC
Right now, the Express Checkout method may not be visible in the payment pane but still would show on the cart form, because we only check to see if it's enabled before altering the form. Part of the problem is the function commerce_paypal_ec_enabled() doesn't return anything that would help us make such a check. We should update that function per its @todo notes and change it to actually return the first enabling rule whose conditions evaluate to TRUE for the given order. This would solve our form issue tangentially and provide us with a meaningful return value for other potential use cases of the function.
Comments
Comment #1
torgospizzaWe need this for our site (specifically, we only want to allow digital orders to be payable using this method, since they don't require shipping fees) so I'd be happy to help out. Maybe in Portland?
EDIT: After talking with Ryan at DC Portland, turns out this might not be a problem for us after all (specifically the Shipping requirements) since we did not appear to have a correct Checkout configuration. Thanks for helping me get this figured out!
Comment #2
rszrama commentedUpdated this right before rollin' the 2.0, though I didn't actually address the full possibility of multiple payment method rules enabling Express Checkout.
Commit: http://drupalcode.org/project/commerce_paypal.git/commitdiff/ac1802a