Download & Extend
Metatag » Issues

Improve support for Open Graph meta tags (video & location & contact)

Posted by Dustin Currie on January 27, 2013 at 10:18pm
Project:Metatag
Version:7.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Nodewords-Metatag feature parity

Issue Summary

See #1278146: [META] Ensure all meta tags are supported for missing or incomplete tags required for a 1.0 release.

This ticket is for patches containing code for OpenGraph tags

Login or register to post comments

Comments

#1

Posted by Dustin Currie on January 27, 2013 at 10:21pm

Patch containing support for:

og:video
og:video:secure_url
og:video:height
og:video:width
og:video:type

AttachmentSizeStatusTest resultOperations
metatag-7.x.1.x-opengraph-1900434-1.patch2.31 KBIdlePASSED: [[SimpleTest]]: [MySQL] 21 pass(es).View details

#2

Posted by DamienMcKenna on January 28, 2013 at 2:00pm
Title:Support for Open Graph Meta tags» Improve support for Open Graph meta tags
Version:7.x-1.0-beta4» 7.x-1.x-dev
Status:active» needs review

Clarified the title.

#3

Posted by System Message on January 28, 2013 at 2:07pm
Status:needs review» needs work

The last submitted patch, metatag-7.x.1.x-opengraph-1900434-1.patch, failed testing.

#4

Posted by bleen18 on January 30, 2013 at 1:34am
Status:needs work» needs review

#1: metatag-7.x.1.x-opengraph-1900434-1.patch queued for re-testing.

#5

Posted by bleen18 on January 30, 2013 at 1:39am
Status:needs review» reviewed & tested by the community

I just played with the patch in #1 and everything looks good. This is certainly a needed addition...

#6

Posted by DamienMcKenna on January 31, 2013 at 6:52pm

Tag.

#7

Posted by j0rd on February 25, 2013 at 8:34am
Title:Improve support for Open Graph meta tags» Improve support for Open Graph meta tags (video & location & contact)
Status:reviewed & tested by the community» needs review

I've added OG Location & Contact information to the original patch.

Since there's no descriptions on Facebook about these fields (and they're pretty self explanatory) I haven't added them in the module.

AttachmentSizeStatusTest resultOperations
metatag-7.x.1.x-opengraph-1900434-7.patch4.8 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch metatag-7.x.1.x-opengraph-1900434-7.patch. Unable to apply patch. See the log in the details link for more information.View details

#8

Posted by System Message on February 25, 2013 at 8:39am
Status:needs review» needs work

The last submitted patch, metatag-7.x.1.x-opengraph-1900434-7.patch, failed testing.

#9

Posted by obleser on March 1, 2013 at 4:18pm

Open Graph != Facebook Graph support!

Open Graph definitions could be found here http://ogp.me/

#10

Posted by j0rd on March 5, 2013 at 3:49am

@obleser. Thanks for pointing that out.

I would assume 90% of the people who're using open graph support with this module are using it because they want to support facebook open graph. I hate not following standards as much as the next person, but we're going to need to support the "big players" in this module for it to be useful for site creators.

With that said, I should probably change my facebook specific stuff into another metatag group instead of open graph group, which should remain standard compliant. I'll look into that when I have some time and make sure my patch applies properly for test bot.

#11

Posted by DamienMcKenna on March 16, 2013 at 8:14pm
Status:needs work» needs review

Rerolled and tidied up a little. I replaced the video type text field with a selector to make life easier.

AttachmentSizeStatusTest resultOperations
metatag-n1900434-11.patch7.21 KBIdlePASSED: [[SimpleTest]]: [MySQL] 21 pass(es).View details

#12

Posted by DamienMcKenna on March 16, 2013 at 8:34pm
Assigned to:Dustin Currie» Anonymous
Status:needs review» fixed

Lets just go with this for now.

#13

Posted by DamienMcKenna on March 24, 2013 at 5:41pm
Status:fixed» closed (fixed)

Now that Metatag v7.x-1.0-beta5 is out am closing this to keep the issue queue clean.

nobody click here