Closed (fixed)
Project:
GeSHi Filter for syntax highlighting
Version:
7.x-1.1
Component:
Filtering
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Jan 2013 at 23:29 UTC
Updated:
11 Feb 2013 at 23:30 UTC
If I change the start number (and nothing else) on an update to existing content, the cached copy of the content is retrieved and the new start number is not enforced.
This is due (apparently) to a simple error in the cache key for previously filtered content.
in geshifilter.pages.inc:
$cache_id = "geshifilter:$lang:$line_numbering:$line_numbering:$inline_mode" . md5($title . $source_code);
should be:
$cache_id = "geshifilter:$lang:$line_numbering:$linenumbers_start:$inline_mode" . md5($title . $source_code);
Patch attached.
| Comment | File | Size | Author |
|---|---|---|---|
| cacheFix.patch | 871 bytes | GWD |
Comments
Comment #1
soxofaan commentedGreat find, thanks
committed to 6 and 7 branches:
http://drupalcode.org/project/geshifilter.git/commit/1e7c73b
http://drupalcode.org/project/geshifilter.git/commit/60cd8d7