This is a problem since we shouldn't implement one without the other.

CommentFileSizeAuthor
#5 fieldable_panels_panes-1900528-5.patch640 bytestim.plunkett
#4 fieldable_panels_panes-1900528-4.patch606 bytestim.plunkett
#1 1900528-build-content.patch3.83 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 1900528-build-content.patch3.83 KB

Patch attached that adds PanelsPaneController::buildContent() and uses it in view(). This brings the entity rendering more in line with core and also entity controllers in D8.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Tested and confirmed, so committed to 7.x-1.x. http://drupalcode.org/project/fieldable_panels_panes.git/commit/7fe67bc

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new fieldable_panels_panes-1900528-4.patch606 bytes 
+++ b/includes/PanelsPaneController.class.phpundefined
@@ -162,21 +162,20 @@ class PanelsPaneController extends DrupalDefaultEntityController {
-    $context = array(
-      'entity_type' => 'fieldable_panels_pane',

@@ -190,12 +189,53 @@ class PanelsPaneController extends DrupalDefaultEntityController {
-    $entity_type = 'fieldable_panels_pane';
-    drupal_alter(array('fieldable_panels_pane_view', 'entity_view'), $build, $entity_type);
+     // Allow modules to modify the structured pane.
+    drupal_alter(array('fieldable_panels_pane_view', 'entity_view'), $build, $context['entity_type']);

You use the $context array below but also remove it.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new fieldable_panels_panes-1900528-5.patch640 bytes

Without call by reference bug.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Thanks, fixed with http://drupalcode.org/project/fieldable_panels_panes.git/commit/1bda8c9

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.