There is using while instead of foreach in views_calc_handler_sort

CommentFileSizeAuthor
#3 views_calc-usind_while_1900714.patch555 bytesa.milkovsky
#1 views_cals_while_using.patch0 bytesa.milkovsky

Comments

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented
StatusFileSize
new views_cals_while_using.patch0 bytes

here is the patch for it

simon georges’s picture

simon georges commented
Status: Active » Needs work

Patch seems to not have been properly uploaded.

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented
StatusFileSize
new views_calc-usind_while_1900714.patch555 bytes

Sorry, you are right. patch was empty.

simon georges’s picture

simon georges commented
Status: Needs work » Needs review
manuelBS’s picture

manuelBS commented

patch is logical and works

simon georges’s picture

simon georges commented
Status: Needs review » Reviewed & tested by the community

Alright, then!

skdrupal88’s picture

skdrupal88
Primary language Russian
Location Belarus
commented

Works for me too.

karens’s picture

karens commented
Issue summary: View changes

This was fixed in dev a while ago.

karens’s picture

karens commented
Status: Reviewed & tested by the community » Closed (fixed)