Problem with recent form_item / form_select change [#19011]

_taxonomy_term_select has been changed to use form_select instead of form_item:

return form_select($title, $name .'][', $value, $options, $description, $multiple ? 'size="'. min(12, count($options)) .'"' : 0, $multiple);

This breaks when $multiple is TRUE, as form_select will add "[]" to $name again!

Comment	File	Size	Author
	taxonomy-multiple.patch	517 bytes	wiz-1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Steven CreditAttribution: Steven commented 18 March 2005 at 08:31

Perhaps it's better and cleaner to fix this by checking the type of vocabulary when validating the terms. In fact there is a bug there at the moment where you could still assign multiple terms in a signle select vocabulary by sending out customized POST data.

Comment #2

drumm

he/him

NY, US

CreditAttribution: drumm commented 18 March 2005 at 19:16

I don't think it is actually broken. I just submitted a new node with two terms selected from each of two vocabularies. And it worked.

Comment #3

wiz-1 CreditAttribution: wiz-1 commented 20 March 2005 at 20:50

Hmm... I agree that it seems to work (tried it right now), but the generated HTML is not clean:

<select name="edit[taxonomy][][]" multiple="multiple"  size="8" id="edit-taxonomy]["><option value="1">...

Note the "edit[taxonomy][][]", which should read "edit[taxonomy][]". I don't clearly remember in what situation it didn't work for me, but it happened. The patch fixes this situation. The id is not pretty either, but that's another story.