Project:GMap Module
Version:7.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Follow up on #1064448: support gmap location cck vertical tabs - HACK to correctly render gmap location cck in vertical tab that looks at the issue displaying Google Maps in hidden containers.

Using the module Panel Tabs, you can bind various panel content into tabs, and no surprises, Google maps hits the exact same issue as the previous thread in that it doesn't render correctly when hidden.

After spending way too much time on this, I went for an overly generic approach that resizes on a hashchange event that is triggered as you change tabs. Works but is probably a bad way of doing this... maybe...

<?php
         jQuery
(elem).parents('fieldset.collapsible').children('legend').children('a').click(r);
        
jQuery('.vertical-tab-button', jQuery(elem).parents('.vertical-tabs')).children('a').click(r);
+       
jQuery(window).bind('hashchange', r);
?>

JQuery tab classes didn't appear to work as selectors, these must be getting added latter.... maybe :?

Marking as "Needs work" as:

a) no patch
b) I have no idea if this is the right way of doing this!

Comments

#1

Status:needs work» needs review

here is a patch with Your changes

AttachmentSizeStatusTest resultOperations
1901654-panel-tabs-support-1.patch626 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1901654-panel-tabs-support-1.patch. Unable to apply patch. See the log in the details link for more information.View details

#2

removed tabs

AttachmentSizeStatusTest resultOperations
1901654-panel-tabs-support-2.patch626 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1901654-panel-tabs-support-2.patch. Unable to apply patch. See the log in the details link for more information.View details

#3

woops

AttachmentSizeStatusTest resultOperations
1901654-panel-tabs-support-3.patch633 bytesIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1901654-panel-tabs-support-3.patch. Unable to apply patch. See the log in the details link for more information.View details

#4

Status:needs review» fixed

thanks
commited pushed to 7.x-2.x and 7.x-1.x dev versions

#5

Cool, I must have been on the right track :)

Thanks

#6

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here