The first time a user connects, there is no session established, so $_SESSION doesn't exist. Trying to unset one item in the uninitialized array triggers this tedious notice.

CommentFileSizeAuthor
#4 1902088-securesite-undefined_SESSION-4.patch965 bytesmgifford
#1 1902088-securesite-undefined_SESSION.patch979 bytesjohn franklin

Comments

john franklin’s picture

john franklin commented
Status: Active » Needs review
StatusFileSize
new 1902088-securesite-undefined_SESSION.patch979 bytes

Reverse the order: set other elements in the array, then unset. If $_SESSION doesn't exist, we implicitly create it by setting $_SESSION['securesite_guest'].

john franklin’s picture

john franklin commented

[removed dup created by clicking "save" twice.]

Nick Robillard’s picture

Nick Robillard commented

Tested and working for me.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes
StatusFileSize
new 1902088-securesite-undefined_SESSION-4.patch965 bytes

That patch failed to apply, so re-rolling it against git.

shivanshuag’s picture

shivanshuag commented

Tested. works for me

NaX’s picture

NaX commented

There is a beta out and it looks like there is different fix to this problem that was committed. Please test the latest dev or beta and let us know if that fixed the problem.