See attached patch. Screenshot of admin screen below. This patch adds a textarea to the admin screen that allows admins to enter CSS selectors (classes and IDs - whatever will be read by jQuery really) that extlink JS will skip over. This is handy if you have areas on the page (menus, blocks, etc.) that you want to not use the normal extlink options on.

Extlink updated admin screen

CommentFileSizeAuthor
#16 extlink6-1902220-16.patch4.18 KBelachlan
#9 CSS-Matching-admin-UI.jpg94.54 KBsokrplare
#8 1902220-0008-Adding-CSS-selector-exclusion-and-explicit.patch4.66 KBsokrplare
#7 1902220-0007-Adding-CSS-selector-exclusion-support.patch3.78 KBsokrplare
#2 1902220-0002-Adding-CSS-selector-exclusion-support.patch3.41 KBsokrplare
Screen shot 2013-01-29 at 9.31.33 AM.jpg62.57 KBsokrplare
0001-Adding-CSS-selector-exclusion-support-so-that-links-.patch3.79 KBsokrplare

Comments

sokrplare’s picture

sokrplare commented
Status: Active » Needs review
sokrplare’s picture

sokrplare commented
StatusFileSize
new 1902220-0002-Adding-CSS-selector-exclusion-support.patch3.41 KB

Tweaked to fix issue if CSS exclusion doesn't match, yet extInclude does.

elachlan’s picture

elachlan commented

I'm going to add my +1 to this as it is a good idea. I haven't tested the patch as of yet.

elachlan’s picture

elachlan commented
Status: Needs review » Needs work

The issue #802562: Only apply in certain DIVs does something similar for including.

We should really merge them and make it "CSS Matching" with a section for both exclude and include.

Could you please re-roll the patch with that change?

sokrplare’s picture

sokrplare commented

Really good idea - unfortunately our contract for this project is up so I won't have time to reroll the patch. Might need this on the next contract and if so, will definitely reroll, but no guarantees right now.

elachlan’s picture

elachlan commented
Title: Add CSS selector exclusion » Add CSS selector inclusion/exclusion

Changing title to be more descriptive.

Thanks for your help covenantd.

Just to make sure, Pattern Matching should take priority over CSS Matching.

sokrplare’s picture

sokrplare commented
StatusFileSize
new 1902220-0007-Adding-CSS-selector-exclusion-support.patch3.78 KB

Hoping to crank this out. First tried applying the patch in #802562: Only apply in certain DIVs, but it is a mess against current version of code (3 years will do that to a patch :).

First step is rebasing this issue's patch against current dev - just a tiny change for that new "Do not include area tags with [sic] begin with mailto".

sokrplare’s picture

sokrplare commented
Status: Needs work » Needs review
StatusFileSize
new 1902220-0008-Adding-CSS-selector-exclusion-and-explicit.patch4.66 KB

Alright, took a very different approach than #802562, but I think it is more consistent with how the pattern matching and CSS exclusion is done. Take a look and then let's get this added!

sokrplare’s picture

sokrplare commented
StatusFileSize
new CSS-Matching-admin-UI.jpg94.54 KB

Here is a screenshot of the admin UI addition for reference.

elachlan’s picture

elachlan commented

Thanks, It looks pretty good. I will see about including it in the next couple of days.

If someone else can review it as well that would be good.

quicksketch’s picture

quicksketch
he/him
commented

This looks great! This has been a missing piece of external links module for a long time. Thanks for taking the time to roll it as a patch. @elachlan thanks for all your work on the module and keep it up. :D

elachlan’s picture

elachlan commented
Status: Needs review » Patch (to be ported)

Commited to Git for 7.x.

Thanks for your help covenantd!!

We need to roll a patch for version 6 and 8 now. I can do that over the next few days.

quicksketch, should we do a 7.x-dev release?

sokrplare’s picture

sokrplare commented

Sweet!

quicksketch’s picture

quicksketch
he/him
commented

quicksketch, should we do a 7.x-dev release?

It'd be better to do a new stable release. We shouldn't be encouraging or asking users to install dev releases. Plus we haven't had a new stable in almost 3 years, we probably have a lot of queued up fixes by now.

elachlan’s picture

elachlan commented

Added a new release!

I will do a release for 6.x once we finish all the ports.

elachlan’s picture

elachlan commented
Version: 7.x-1.12 » 6.x-1.x-dev
Status: Patch (to be ported) » Needs review
StatusFileSize
new extlink6-1902220-16.patch4.18 KB

Patch for 6.x

elachlan’s picture

elachlan commented
Status: Needs review » Closed (fixed)

Version parity :)

elachlan’s picture

elachlan commented
Issue summary: View changes

Adding a few more words for Google-fu