Posted by emmajane on January 30, 2013 at 2:35am
2 followers
Jump to:
| Project: | Omega |
| Version: | 7.x-4.x-dev |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
Currently the wizard has the following step:
Please choose a destination. This is where your sub-theme will be placed
Please choose a destination type.
[0] : Cancel
[1] : Site (e.g. 'all' or 'example.com')
[2] : Installation profile
[3] : Parent theme It almost feels like a step is missing between the first two lines of instructions, but it seems like the first line (please choose a destination) will never have a select list of options associated with it?
Perhaps this could be changed as follows:
Theme folder location. This is where your sub-theme will be placed.
Please choose a destination type.PS I'm using the git branch 7.x-4.x.
Comments
#1
Should we remove this feature (selecting a destination) and instead always place the theme in sites/all? There is another problem with it: #1901562: Currently 'drush osub' & 'drush owiz' always enable / set the default theme on the current site even if placed elsewhere.
#2
I just refactored the way omega-wizard and omega-subtheme play together. Originally they both used a shared API function. Now, omega-wizard builds on omega-subtheme instead and invokes it internally after setting the options accordingly.
@see http://drupalcode.org/project/omega.git/commitdiff/acacc0580a91089d2046b...
It would be pretty simple now to add a validation step that checks if the theme that was just created lies in the current scope of the drush command (e.g. in sites/all or the same multisite instance that the drush command was invoked from). Alternatively we could add a check that only allows you to place the theme in either sites/all, the active profile, the active multisite or a theme that is in the current scope (one of the aforementioned three). The last solution sounds like it's the cleanest but it might confuse people when they don't see their site.example.com appear even though they have a directory for it. Thoughts?
#3
I think you're solving a different problem? I'm just referring to the text of the instructions:
Please choose a destination. This is where your sub-theme will be placedPlease choose a destination type.
These two statements are stacked together with what seems like two questions:
Please choose a destination.and
Please choose a destination type.I would like the instructions to be simplified so that only one choice is offered.
... unless something is broken and
Please choose a destination. This is where your sub-theme will be placedis supposed to have a series of options associated with it?