Im using the latest dev-build.

As far as i can see we have the following .css files in the base-theme:

 /css/app.css [ ? ]
/css/drupal.css [drupal overrides]
/css/foundation.css [foundation base styles]
/css/foundation.min.css [minified foundation base styles, can be switched in base-theme .info file]

and the starter-theme ships with
/css/custom.css [sub-theme styles] (although in its .info file it includes /css/drupal.css < This may be a typo.)

I'm not quite sure for what the app.css file is used for; in the latest dev it contains many of the styles found in foundation.css. And it seems as if these styles are loaded twice when i'm inspecting an element with firebug. Is this on purpose?

I'm wondering what app.css is used for?

Thanks for any clearification,
Frank

Comments

ishmael-sanchez’s picture

ishmael-sanchez commented
Category: bug » task

Hi Frank,

Do you use sass at all? If you do look in the sass folder the app the app.scss folder pulls in the base styles. I see what you mean it is a bit unclear. I suppose we could dump the app.css in the base theme and just add a line/note in the info of the starter file to uncomment if you are using sass? Do you have any suggestions. The main goal is to support sass but not force it down every themers throat.

Knarf31’s picture

Knarf31 commented

Hi ishmael,

thanks for replying. No, i don't use sass at all.
I'm not a pro in coding .html and .css but it is enough for basic sites.
So far i'm only using the custom.css in my sub-theme.

I'm quite happy with only using custom.css and your way of not forcing noobs like me to use sass.

My suggestion is keep it clean and simple in the starter-theme and add comments to use sass for pro's to uncomment.
Just like you said.

I'm still wondering about line 30/31 in \STARTER\starter.info:

; Base theme specific CSS
stylesheets[all][] = css/*drupal*.css

because there is no drupal.css in \STARTER\css\

Shouldn't that say "stylesheets[all][] = css/*custom*.css" ?

Thanks for your work, i highly appreciate it!

Bcwald’s picture

Bcwald commented

I believe this to be an error. in the starter theme custom.css is given as a a blank css sheet to work with, not drupal.css (which is in the main framework). My guess is it was a copy over error.

chrisjlee’s picture

chrisjlee commented

@SweetCircus Yes you're right that would be this bug with the drush subtheme creation: #1907922: Drush Subtheme .info file doesn't include the renamed custom.css

@ishmael-sanchez Should we support an argument in our drush command to generate a sassified version? And our non-css friends can use a regular theme without sass files as well.

chrisjlee’s picture

chrisjlee commented

It's probably about time. so I started a book page. I'll slowly add documentation in as i have more time:

http://drupal.org/node/1928104

timani’s picture

timani commented

Thanks for starting that doc page chrisjlee.

Is there an outline of how the docs are to be structured or is that TBD?

If there is a general idea of the pages that are needed I could help out with the documentation.

chrisjlee’s picture

chrisjlee commented

Timani27:

Good points. I think we can just start working on an outline here.

I'd like to hear your feedback as well:

  • Why use foundation?
  • Installation
  • Getting Started
    • creating a subtheme
  • Using Sass
  • Directory Structure
  • Recommended Contributed Modules

Some things to consider would be also the versioning.

timani’s picture

timani commented

Yea, i think versioning will definitely be important especially as 4 gets better integrated. Maybe having the structure based on the version of the module or possibly another convention?:

  • ZURB Foundation 7.x
  • ZURB Foundation 8.x
  • ZURB Foundation ...
  • ZURB Foundation x.x

Based on the initial outline, maybe some sub-sections within each top level group that should written up. Sections like Directory Structure i did not do anything on so feedback is needed:

  • Installation
    • Admin Interface
    • FTP/manual
    • Drush
  • Getting Started
    • Creating a subtheme
      • Manual
      • Drush
    • Customizing a sub-theme?
  • Using Sass
    • About Sass
    • Installation
    • Zurb gem
    • Zurb Compass
    • Scss settings
      • _base.scss
      • _settings.scss
      • app.scss
  • Directory Structure
  • Recommended Contributed Modules
    • Panels
    • Block class?

Eventually getting a way to document best practices around how to integrate foundation elements.

chrisjlee’s picture

chrisjlee commented

timani:

Looks good to me. I like what you've done here. I don't really have many changes except maybe the scss settings file should be one page.

  • Scss settings
    • _base.scss
    • _settings.scss
    • app.scss

Also, we want to reinforce to users to rely on the Zurb documentation for certain things from gem installation, and updating it. Zurb foundation does a great job already with their gem installation documentation. Also would reminder users to use the zurb documentation as it's going to be updated more than ours.

timani’s picture

timani commented

I created the basic pages and book structure.

Over the weekend I will be doing a couple of sprints so I will most probably start adding content to those pages too.

chrisjlee’s picture

chrisjlee commented

Thanks timani for the page updates. I went ahead and started to add in content. Looking for others to review it if they have a moment.

timani’s picture

timani commented

Looking good. I will be back in the fold soon and can put in some work on the docs.

Also saw the update to foundation 4!

chrisjlee’s picture

chrisjlee commented

Going to declare this fixed for now. I did some edits to complete the documentation for the 1.x branch. Will now need to move toward the 4.x Branch #2028753: [META] Zurb Foundation Drupal 4.x Documentation

chrisjlee’s picture

chrisjlee commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.