Watchdog Array [#1903002]

I'm not sure if this is permitted, so please just shut down this review if it doesn't abide but the correct rules of the review-process. I've had a project through this process before and have been granted permissions to create full projects, but the review-process allowed me to get comments and see my own project from a whole different light, so now that I have another (tiny) module, I was hoping to put it through the same process, but of course, just for the review itself, not for advancement of my user-permissions.

---

This is a tiny module that basically adds an extended watchdog function, named watchdog_array. My new function has an extra argument, inserted as the third argument, that supplies an array. This array is put through print_r and wrapped in

 and added to the message before run through a normal watchdog command.

The point is of course to be able to pass arrays to the be logged. A great tool for debugging.

Project:
http://drupal.org/project/watchdog_array

git clone:
git clone --recursive --branch 7.x-1.x http://git.drupal.org/project/watchdog_array.git watchdog_array

Drupal version:
7.x

Comments

Comment #1

alexmoreno commented 30 January 2013 at 20:14

The code is very well documented, as it is the watchdog_array function.

You delete the variables when unistalling the module and it has no issues with the paraview tool: http://ventral.org/pareview/httpgitdrupalorgsandboxpdnagilum1902908git

Unfortunately, the code is too brief, there is to few code to review. It is recommended to write at least 200 or 300 lines of code, and at least 4 or 5 functions to really undertand your comprehension of the drupal way of working.

Also adding at least 3 or 4 reviews of other codes will help to approve your module asap.

Thank you.