Strict warning: Only variables should be passed by reference in makemeeting_field_formatter_view() (line 515 of /Applications/MAMP/htdocs/nittany-7.x-1.x-dev/sites/all/modules/makemeeting/makemeeting.module).
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 1903144-4-entity_extract_id_strict_warning.patch | 642 bytes | SebCorbin |
| #1 | strict-warning-1903144.patch | 0 bytes | btopro |
Comments
Comment #1
btopro commentedPatch to resolve issue, very minor code shuffle so reset() isn't called inline with entity id return data.
Comment #2
SebCorbin commentedPatch is empty :)
Comment #3
btopro commentedhmm... that was weird... $entity_ids = entity_extract_ids($entity_type, $entity); needs to be set to a variable and then reset, can't be done inline at least with some vesions of PHP.
Here's the function to alter at least:
Comment #4
SebCorbin commentedHow about that, testbot?
Comment #6
btopro commented? is there something wrong w/ the tests cause neither this or the other patch I submitted are dangerous at all, yet are reporting failing. lol
Comment #7
SebCorbin commentedYes, testbot was messing with us, this is committed, thanks!