I have installed the module on my live site. Everything worked great, except the comment signatures are now double.

Amnon
-
Professional: Drupal Israel | Drupal Development & Consulting | בניית אתרים
Personal: Hitech Dolphin: Regain Simple Joy :)

CommentFileSizeAuthor
#6 sig_comment.jpg19.96 KBKirk

Comments

druvision’s picture

additional inflammation:

The signature will continue to be planted into the editable new comment field, even though the forum_comment module plants it automatically. That first comment is editable. The second comment is automatic. The result is double comment. got a comment. Double comment can only be avoided by deleting the first editable comment.

liam mcdermott’s picture

Assigned: Unassigned » liam mcdermott
Priority: Normal » Critical

This is certainly a horrible bug. Am investigating it now.

liam mcdermott’s picture

Status: Active » Postponed (maintainer needs more info)

additional inflammation:

By the way I think you meant 'additional information'. 'Inflammation' is an area of puffed up skin, usually due to an infection or injury. It can also mean violent or excited emotion. 'The people were in a state of extreme inflammation'. It might be that you were trying to tell me that the first comment being editable made you even more angry than you were before. ;)

Anyway, not trying to be patronising--your English is better than my Hebrew--but the people I've met who have English as a second language have always complained that people don't correct them enough. :)

*** Back on-topic ***

Think the problem has been tracked down, some questions need answering to clarify:

  1. Does the problem appear on new posts, or only existing ones?
  2. Is the signature repeated on nodes, comments or both?
  3. Are you able to have a look at the user table and let me know whether the signature field is blank (for all users), please?
  4. What database engine are you using?

Sorry for all the questions, need to make sure that my findings are correct, before running-off a patch.

jayjenxi’s picture

There's a way to hide the repeated signature.

Add this to your style.css file of your theme.

/**
  * Fix duplicate signature problem 
  */
div.author-signature {
  display: none;
}

I found this information from: http://drupal.org/node/62746

liam mcdermott’s picture

jayjenxi, that doesn't seem to work on the current default theme. I haven't actually properly tested it, but the signature is not inside a div. The permanent solution (if a little hackish) would be to run through all the comments and delete the signature out of them. Am working on that at the moment.

Kirk’s picture

StatusFileSize
new19.96 KB

I'm a tad confused about what you are describing, so I'm *not certain* my issue is the same.

In my case the signature is being inserted into the comment field. So, the user either has to delete it or it shows up as part of the comment. The attached image illustrates the issue.

I would also like to note that this occurs in comments fields in which TinyMCE IS NOT enabled as well.

Other than this, the module seems to work great though :)

liam mcdermott’s picture

In my case the signature is being inserted into the comment field. So, the user either has to delete it or it shows up as part of the comment.

Thanks for this sparq-l. It sounds like you're having the same trouble as levavie. Two questions for you:

  1. Could you please have a look at your users table and tell me if the signature field is blank for all users?
  2. Please let me know what database engine you're using, e.g. MySQL, PostgreSQL

Have tried reproducing this with a test system and a completely clean install of Drupal and it seems to work (bug does not appear). Am rather confused about what the problem could be!

This module should remove all the signatures from the existing table, so Drupal does not include them in comments. Will carry on testing while awaiting your reply. :)

Kirk’s picture

1. Signature field appears blank for all users
2. We're on MySQL 4.1.22

If you're interested in taking a look at it live, let me know and I can give you a login.

liam mcdermott’s picture

If you're interested in taking a look at it live, let me know and I can give you a login.

Yes please, I would like a login. Can't seem to reproduce the bug here!

Kirk’s picture

OK man, I sent you an email with the login info.

liam mcdermott’s picture

Status: Postponed (maintainer needs more info) » Fixed

The problem was being caused by Organic Groups, which is why I couldn't reproduce it. I've committed a fix, the next packaging run will happen at 12:00pm GMT, when the fix will become available. Make sure you either have a backup, or you don't mind losing all your data before testing this: it deletes any existing signatures from the comments table. There's a remote chance it could delete all the data in comments too.

update.php will need to be run after untarring the new version too.

Thanks for the access sparq-l, it provided the clue needed to find the root of the problem. :)

liam mcdermott’s picture

Make sure you either have a backup, or you don't mind losing all your data before testing this: it deletes any existing signatures from the comments table. There's a remote chance it could delete all the data in comments too.

This has been changed so it's optional. There's now a setting in the admin form to delete old signatures from comments. You can install without fear now. :)

Kirk’s picture

New version works wonderfully! Great work, man.

druvision’s picture

Status: Fixed » Active

Hi Liam,

Yes, I have organic groups installed.
Yes, I meant 'more information', not the other word.

Today I've tried your new version on my live site - and it's half solved.

The default signatue does not appear as editable text on new comments.

But, even after I checked 'Deleted Embedded Signatures', old comments still appear twice. Sample page: http://drupal.org.il/node/1494#comment-2526 - you can see that the comments of boaz still appear.

Amnon

liam mcdermott’s picture

Status: Active » Postponed (maintainer needs more info)

The default signatue does not appear as editable text on new comments.

But, even after I checked 'Deleted Embedded Signatures', old comments still appear twice. Sample page: http://drupal.org.il/node/1494#comment-2526 - you can see that the comments of boaz still appear.

Thanks for the sample, I can see you're still having the problem on your site. Sorry for not replying sooner, haven't got much time to work on this stuff this week.

I have a question about the post on that page. Which of the following is true:

  1. the signature was already embedded into the post, enabling the signature_forum module duplicated it and checking the 'Delete embedded signatures' didn't help, or;
  2. whenever a new post is created the signature is printed twice, checking 'Delete embedded signatures' doesn't help?

Have to ask as I can't seem to reproduce the problem with OG myself. Also worth noting: the 'Delete embedded signatures' option will only work if the signature is exactly the same as what's in the signature field, with no extra characters after it.

liam mcdermott’s picture

Status: Postponed (maintainer needs more info) » Fixed

Am going to assume this is fixed. Please re-open the issue if it's not. Thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

segfaultmaker’s picture

#4 solved the problem here ;)