I have installed the module on my live site. Everything worked great, except the comment signatures are now double.
Amnon
-
Professional: Drupal Israel | Drupal Development & Consulting | בניית אתרים
Personal: Hitech Dolphin: Regain Simple Joy :)
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | sig_comment.jpg | 19.96 KB | Kirk |
Comments
Comment #1
druvision commentedadditional inflammation:
The signature will continue to be planted into the editable new comment field, even though the forum_comment module plants it automatically. That first comment is editable. The second comment is automatic. The result is double comment. got a comment. Double comment can only be avoided by deleting the first editable comment.
Comment #2
liam mcdermott commentedThis is certainly a horrible bug. Am investigating it now.
Comment #3
liam mcdermott commentedBy the way I think you meant 'additional information'. 'Inflammation' is an area of puffed up skin, usually due to an infection or injury. It can also mean violent or excited emotion. 'The people were in a state of extreme inflammation'. It might be that you were trying to tell me that the first comment being editable made you even more angry than you were before. ;)
Anyway, not trying to be patronising--your English is better than my Hebrew--but the people I've met who have English as a second language have always complained that people don't correct them enough. :)
*** Back on-topic ***
Think the problem has been tracked down, some questions need answering to clarify:
Sorry for all the questions, need to make sure that my findings are correct, before running-off a patch.
Comment #4
jayjenxi commentedThere's a way to hide the repeated signature.
Add this to your style.css file of your theme.
I found this information from: http://drupal.org/node/62746
Comment #5
liam mcdermott commentedjayjenxi, that doesn't seem to work on the current default theme. I haven't actually properly tested it, but the signature is not inside a div. The permanent solution (if a little hackish) would be to run through all the comments and delete the signature out of them. Am working on that at the moment.
Comment #6
Kirk commentedI'm a tad confused about what you are describing, so I'm *not certain* my issue is the same.
In my case the signature is being inserted into the comment field. So, the user either has to delete it or it shows up as part of the comment. The attached image illustrates the issue.
I would also like to note that this occurs in comments fields in which TinyMCE IS NOT enabled as well.
Other than this, the module seems to work great though :)
Comment #7
liam mcdermott commentedThanks for this sparq-l. It sounds like you're having the same trouble as levavie. Two questions for you:
Have tried reproducing this with a test system and a completely clean install of Drupal and it seems to work (bug does not appear). Am rather confused about what the problem could be!
This module should remove all the signatures from the existing table, so Drupal does not include them in comments. Will carry on testing while awaiting your reply. :)
Comment #8
Kirk commented1. Signature field appears blank for all users
2. We're on MySQL 4.1.22
If you're interested in taking a look at it live, let me know and I can give you a login.
Comment #9
liam mcdermott commentedYes please, I would like a login. Can't seem to reproduce the bug here!
Comment #10
Kirk commentedOK man, I sent you an email with the login info.
Comment #11
liam mcdermott commentedThe problem was being caused by Organic Groups, which is why I couldn't reproduce it. I've committed a fix, the next packaging run will happen at 12:00pm GMT, when the fix will become available. Make sure you either have a backup, or you don't mind losing all your data before testing this: it deletes any existing signatures from the comments table. There's a remote chance it could delete all the data in comments too.
update.php will need to be run after untarring the new version too.
Thanks for the access sparq-l, it provided the clue needed to find the root of the problem. :)
Comment #12
liam mcdermott commentedThis has been changed so it's optional. There's now a setting in the admin form to delete old signatures from comments. You can install without fear now. :)
Comment #13
Kirk commentedNew version works wonderfully! Great work, man.
Comment #14
druvision commentedHi Liam,
Yes, I have organic groups installed.
Yes, I meant 'more information', not the other word.
Today I've tried your new version on my live site - and it's half solved.
The default signatue does not appear as editable text on new comments.
But, even after I checked 'Deleted Embedded Signatures', old comments still appear twice. Sample page: http://drupal.org.il/node/1494#comment-2526 - you can see that the comments of boaz still appear.
Amnon
Comment #15
liam mcdermott commentedThanks for the sample, I can see you're still having the problem on your site. Sorry for not replying sooner, haven't got much time to work on this stuff this week.
I have a question about the post on that page. Which of the following is true:
Have to ask as I can't seem to reproduce the problem with OG myself. Also worth noting: the 'Delete embedded signatures' option will only work if the signature is exactly the same as what's in the signature field, with no extra characters after it.
Comment #16
liam mcdermott commentedAm going to assume this is fixed. Please re-open the issue if it's not. Thanks.
Comment #17
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #18
segfaultmaker commented#4 solved the problem here ;)