Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Well I was working on the same port that you are have created here, although I can see I'm a week too late.
The only suggestion I have is, instead of hard-coding the warning strings in the js, put them in the module file (inside the function where you are already adding the js) and use the identical code from the Drupal 6 version to add the code (I think using drupal_to_js('blah', 'settings') or something similar), but wrap the strings in the t() function.
Does this make sense? This way other developers can use the translation system to translate those strings easily in Drupal 5.x.
Good work, nifty module.
Dave
Comments
Comment #1
jrbeemanGood idea - I'll take a look at this.
Comment #2
jrbeemanI guess you learn something new every day! I didn't realize Drupal 5 had the widely-used-in-Drupal 6 capability of adding settings via drupal_add_js. This is pretty slick. I've committed the changes to the 5.x-dev branch.
Comment #3
jrbeemanFixed in 5.x-1.0 release