Add https support

This patch worked for me. I read on Discus.com that the correct way to do this is to use // instead of the check for http/https but like I said, this fixed my problem.

7.x-1.x already uses implicit protocol (//) and it proved to work fine. We should definitely use the same aaproach with 6.x-1.x.

Hi guys,

Attached a patch which adds HTTPS support on both levels: PHP and Javascript.
Please review.

Thanks,
Konstantin

Committed. Thanks!

Unfortunately, I don't see the commit. Could you please also push changes to the repo?

Thanks,
Konstantin

Should be pushed now.

Please learn the following article Adding a commit author before you commit others' code next time.

I always do this when there is only one author of a patch. This patch was tecnically contributed by you and @Mixologic and it is not possible to add both as authors. You are both listed in commit message which is main autorship attribution technique in Drupal community.

Thanks for the explanation @slashrsm.

Although, let me disagree with you. My patch was physically contributed by me only. You may look at dates of comments. We didn't work together on this patch. Also, it was not a re-roll. I just needed this to be solved one day, looked for similar issue and attached the patch to a comment of existing issue instead of opening a new one.

For some people including me it is important to have their contributions listed on their profile. We spend tons of time to contribute, don't we deserve a small appreciation?
Anyway, there is nothing here you can help with anymore.

Thanks for your assistance in reviewing the patch.

Best,
Konstantin

I can agree with most of what you wrote. However... only listing you as an author would be injustice to @Mixologic, who also contributed to this issue. I agree.... Your patch was fresh, but it is about the issue, not about the patch. All people that contributed to some issue should be listed.

It happens a lot of times that initial solution changes to something completeley different, but you cannot say that only author of that last iteration contributed to the solution.

Also... AFAIK it is Drupal guideline to use --author tag for issues where only one person contributed (or contributed majoritiy of it), but to ommit it where more people cooperated. I've been following this rule since git migration.

I do not plan to discuss this any further.

Thank you for your patch.

@Mixologic, thank you for the link and your understanding.
The format-patch solution is good, but not all of us use it and even understand how to process its patches. This issue is also mentioned in comments of the article you shared.
I personally think that we need something more intelligent or automatic than format-patch or a drush command.

As I understood from @slashrsm explanation, that is a common approach in Drupal community to avoid setting the proper Git attribution in case an issue involves several contributors. If so, I don't see reasons to contribute patches to such issues. I consider contribution time as marketing expenses, so, if I don't have publicly available indication of my activity, such activity doesn't make sense.

In my opinion, Dries and Association should realize that the project is too big and complex to work for idea only. We need more sophisticated and intense motivation.

The *real* issue here is that the only contributions that are reflected on our profile pages are the authorship contributions. It would actually be better if they were somehow able to parse the commit logs for usernames and provide attribution that way as well.

Great idea with the parsing of commit messages, especially if the format is standardized and predictable.
Can somebody push this idea to people who are responsible for community motivation and Drupal.org project?

Thanks,
Konstantin

I contribute patches and support because I make a living off of the sum total of everybody else's contributions.

I contribute back by a bunch of different ways and contribute more than many others, just believe me.
And one more thing I wanted to add, an ideology is great until you want to eat.

@konstantin.komelin: Please read this https://drupal.org/node/52287#credit

Not everybody feels that way. I contribute patches and support because I make a living off of the sum total of everybody else's contributions. Collectively, we've created a massively valuable thing. I personally feel obligated to give back so that I can feel like I'm paying the community back.

Most people feel like this. And once again: I agree that authorship needs to be specified with every commit. I've done this in commit message, which has been Drupal's common practice for ages. Period.

@konstantin.komelin: Please read this https://drupal.org/node/52287#credit

Thanks. I'm familiar with the rules. I have been maintaining modules for several years.
However, as @Mixologic mentioned, the system is not ideal and can be improved by parsing commit messages, for instance.
You should know, I'm not trying to blame you in something or convince you, especially after that:

I do not plan to discuss this any further.

We are discussing the issue with @Mixologic.

Most people feel like this.

Okay. But how many from the million of users? There are a few contributors from this mass of people, and I believe we deserve some acknowledgment.

Anyway, I think I've expressed my opinion completely and am not going to discuss it any more.

Thanks,
Konstantin

Hey guys, this discussion isn't really related to the ticket so much as the process around resolving tickets. Please take it to the appropriate forum. Thanks.

Hey @peggysmouse. We've just finished the discussion.
Thanks for reminding us about the importance of keeping the discussion relevant to the issue.

Best,
Konstantin