I've already got responsive_bartik installed in a distribution I'm building. I'm favorable toward Panopoly's layouts, but I'm a responsible guy and I think I should manage my own dependencies. Therefore, I do not wish for panopoly_theme to download and install responsive_bartik at this time. I understand that there are some patches panopoly_theme.make applies to responsive_bartik, but I'm willing to pick and choose from those when/if that is necessary.

Anyone else who is working this way can use this patch in their makefile and it will remove panopoly_theme.make from the module.

CommentFileSizeAuthor
#14 panopoly_theme-makefile-free-1904766-14.patch904 bytessaltednut
#13 panopoly_theme-makefile-free-1904766-13.patch808 bytessaltednut
#6 panopoly_widgets-no-defaultconfig-1949710-6.patch10.7 KBsaltednut
#5 panopoly_theme-makefile-free-1904766-5.patch1.05 KBsaltednut
#2 panopoly_theme-makefile-free.patch1.18 KBsaltednut
panopoply_theme-makefile-free.patch1.18 KBsaltednut

Comments

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented 
projects[panopoly_theme][type] = "module"
projects[panopoly_theme][download][type] = "git"
projects[panopoly_theme][download][url] = "http://git.drupal.org/project/panopoly_theme.git"
projects[panopoly_theme][download][revision] = "4f458877f968e61f32974f5c3e24464f1ef59cb4"
projects[panopoly_theme][subdir] = "contrib"
projects[panopoly_theme][patch][1904766] = "http://drupal.org/files/panopoly_theme-makefile-free.patch"
saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
StatusFileSize
new panopoly_theme-makefile-free.patch1.18 KB
saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Title: Panopoly Theme contains a make file that conflicts with other distributions intent for responsive_bartik » Remove makefile from Panopoly Theme
Status: Closed (won't fix) » Active

It would benefit other distributions that use responsive_bartik if it was moved out of panopoly_theme and into the panopoly drupal-org.make

The patch in #2 posted proposes a radical shift in panopoly architecture where none of the modules contain their own makefile.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Priority: Minor » Normal
saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
StatusFileSize
new panopoly_theme-makefile-free-1904766-5.patch1.05 KB

Rerolled #2

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
StatusFileSize
new panopoly_widgets-no-defaultconfig-1949710-6.patch10.7 KB

Attached patch was posted to wrong issue queue. Sorry!

kmonty’s picture

kmonty
He/Him
Location Berlin, DE + SF, CA
commented
Status: Active » Needs review
populist’s picture

populist commented
Status: Needs review » Postponed (maintainer needs more info)

Why not just override it using the "Overriding Properties" in drush make?

http://drupalcode.org/project/drush_make.git/blob_plain/refs/heads/6.x-2...

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Postponed (maintainer needs more info) » Needs review

The patch in #2 posted proposes a radical shift in panopoly architecture where none of the modules contain their own makefile.

This is a feature request.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented

Additionally, since the makefile is loaded via recursion, I do not believe the override would take effect.

populist’s picture

populist commented
Status: Needs review » Postponed (maintainer needs more info)

It might be worth checking out #1989188: Make recursion work with our makefile for how Open Atrium handles recursive makefiles. Does that let you override?

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Project: Panopoly » Demo Framework
Status: Postponed (maintainer needs more info) » Active

IDK, I can't really get behind that as a fix. Its a workaround. A few reasons why this won't work for DF.

1. We don't use responsive bartik or radix - I can't override them and say "don't download" - so if I don't patch them out, we have cruft in DF.

2. What its actually doing in Atrium: the panopoly_theme.make downloads one version of the module/theme then later in the build Atrium downloads the same thing again but with whatever overrides/patches are necessary.
-- I don't like this because it extends the already lengthy build process - its bad enough that we have to hit d.o. all day long for module downloads but to straight up download the same module twice for a single use is not ideal.

I'm going to move this out of your issue queue @populist, it doesn't really concern Panopoly what DF does with its makefiles. As a decoupled distribution, Panopoly includes makefiles with its modules. That's fine - I see why it needs to be there, we just can't have it on our case.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Category: Feature request » Task
Issue summary: View changes
StatusFileSize
new panopoly_theme-makefile-free-1904766-13.patch808 bytes

Updated for latest version of panopoly_theme module.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
StatusFileSize
new panopoly_theme-makefile-free-1904766-14.patch904 bytes

Updated for panopoly_theme 1.14

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Active » Closed (outdated)