The module presently displays the tagging form whenever a node is in full view on the page, assuming this means it is the only one. When more than one node is displayed in full view (ie not teaser), the tagging form is broken. Specifically, the submit button is missing on the first node, while the text field is missing on all the other nodes.
As fixing the module to allow more than one tagging form per page is beyond me, instead I submit a fix that only displays the tagging form when the node is the only one on the page. This is done by replacing the !$teaser with a $page condition.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | community_tags-teaser-view-190480-1.patch | 1.13 KB | cburschka |
| community_tags-teaser-view-190480-0.patch | 849 bytes | cburschka |
Comments
Comment #1
cburschkaNewbie error there. I didn't test thoroughly and overlooked that the implementation of hook_nodeapi doesn't define the $page argument. This patch adds it.
Comment #2
KentBye commentedI'll have to take a look at this since soon since I filled an issue about adding support for tagging nodes in teasers.
There was a patch that nedjo wrote that did it, but also added other stuff that broke deleting tags among other things.
Comment #3
cburschkaWell, if that is added (without breaking things), then this less desirable workaround becomes superfluous. I hope it will be configurable though.
Comment #4
KentBye commentedJust wanted to add that it appears as if Steven Wittens is no longer the maintainer, and it appears as if he's passed the torch onto owahab.
So the adding support for tagging nodes in teasers change is lot more involved and complicated, and I'm not sure if your change is a logical first baby step considering that there are a little over 40 active issues in the queue.
Comment #5
cburschkaPresently, it's broken. Normally you don't notice this, but if you replace your front page with a different View that displays full nodes (which I have done), you get messed-up forms. This is because the logic in the module is incorrect in equating "!$teaser" with "$page". Just because a node is displayed in full does not make it the only one.
My patch removes this broken functionality, the other patch would fix the functionality.
If the other patch has any chance at getting in soon, I would say skip this completely and work on that instead. It's a bug that generally only occurs if you use Views.
Comment #6
dropcube commentedCould you guys provide an updated patch for this?
Comment #7
chaps2 commentedThis is definitely fixed in 6.x-1.0-beta4 and above, possibly before.